--- Log opened Sun Jan 03 00:00:04 2021 00:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 02:32 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds] 02:34 -!- jonatack [~jon@88.124.242.136] has joined ##miniscript 02:35 -!- jonatack [~jon@88.124.242.136] has quit [Client Quit] 02:49 -!- jonatack [~jon@88.124.242.136] has joined ##miniscript 03:00 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 264 seconds] 03:01 -!- jonatack [~jon@213.152.162.99] has joined ##miniscript 03:15 -!- jonatack [~jon@213.152.162.99] has quit [Quit: jonatack] 03:15 -!- jonatack [~jon@213.152.162.99] has joined ##miniscript 07:02 < andytosh1> sanket1729: i did miss that (was just about to go check my logs) 07:02 < andytosh1> sanket1729: so, on #rust they suggested that I just use RefCell in my calling code 07:03 < andytosh1> which I did, which worked fine 07:04 < andytosh1> the problem with having a Key|Hash function that retuns a Key|Hash is that we need to somehow unpack the correct type from the return value, which at the very least will introduce new error paths 07:27 < andytosh1> sanket1729: merged 217. think we're ready for another release? 08:02 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Read error: Connection reset by peer] 08:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer] 08:02 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Read error: Connection reset by peer] 08:07 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined ##miniscript 08:08 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined ##miniscript 08:09 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined ##miniscript 08:39 < andytosh1> 15:03 < andytosh1> which I did, which worked fine 08:39 < andytosh1> lol, OTOH you have to use RefCell for *everything* you put into these closures that you might want to mutate ... it is pretty annoying 09:13 < andytosh1> in core, if i import the same descriptor with various overlapping ranges, how does it handle this? 09:18 < andytosh1> sanket1729: we should have variants of translate_pk that can check whether some predicate is true for all keys 09:18 < andytosh1> that one could take a Key/Hash variant 09:24 -!- andytosh1 [~apoelstra@wpsoftware.net] has quit [Changing host] 09:24 -!- andytosh1 [~apoelstra@unaffiliated/andytoshi] has joined ##miniscript 09:24 -!- andytosh1 is now known as andytoshi 10:01 < sanket1729> andytosh1: should we wait for rust-bitcoin release? 10:04 < sanket1729> andytosh1: what is the use of that predicate? 10:18 < andytoshi> sanket1729: e.g. determining whether a given key has been cached already 10:18 < andytoshi> or just running some arbitrary code on every key 10:32 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined ##miniscript 11:08 < sanket1729> I see. It does seem useful. Should we also think about 186 issue? Trying to distinguish descriptors before and after derivation? 11:14 < andytoshi> yeah, i've been thinking about it 11:14 < andytoshi> definitely we should have some sort of accessory that'll tel you whether a descriptor is derived or not 11:14 < andytoshi> but knowing this by itself doesn't give you a lot more functionality does it? 11:15 < andytoshi> aside from e.g. warning the user that he's provided a range but the given descriptor is fixed 11:45 < sanket1729> We don't have any dummy things that we do now? I guess after we removed desceiptorkeyctx, we don't have dummy index 0 stuff anymore 11:45 < sanket1729> Also for release, should we wait for rust-bitcoin? 11:52 < andytoshi> sanket1729: we could 11:52 < andytoshi> who knows how long that'll be :( 11:55 < andytoshi> we should just fork rust-bitcoin so we can merge shit without being held up :P 11:56 < sanket1729> I see. I was excited to try some taproot stuff. The new rust-bitcoin has signet support. And I think we could do some taproot stuff 11:57 < andytoshi> yeah, there are a zillion things in the new rust-bitcoin release .... we just need to get these last PRs over the finish line 11:58 < andytoshi> and if travis hadn't chosen this week to fuck up maybe we would've done it before the new year 11:58 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 260 seconds] 11:59 < sanket1729> Sure, we can do a release. Let me look at the remaining issues once 12:06 < sanket1729> andytoshi: I think we are good for release. I am away on PC now. I can make a release PR tomorrow, or if you want the release today, I can review a release PR from you. 12:06 < andytoshi> nah, let's wait for tomorrow 12:06 < andytoshi> and see where rust-bitcoin winds up 12:10 < andytoshi> rust-secp 0.20 merged :) 12:34 < sanket1729> Awesome 14:35 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined ##miniscript 14:49 < sgeisler> sanket1729: a `is_derivable` function for descriptors would be useful. I implemented it myself to avoid an infinite loop when scanning a wallet with gap limit (would get stuck if not derivable and if it ever held an UTXO) https://github.com/sgeisler/rust-electrum-client/blob/assetman/src/api.rs#L85 14:49 < sgeisler> So maybe I should just PR it? 14:56 < andytoshi> lol @ that function recursing through the entire descriptor and cloning everything 14:56 < andytoshi> sgeisler: would be good to PR a general "check a predicate on every key" function and then implementing is_derivable in terms of taht 14:58 < sgeisler> Agreed. I just needed a quick fix and network latency dominated anyway ^^ A PR version should so something sane instead. 17:49 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 258 seconds] 21:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 21:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined ##miniscript 22:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving] 22:36 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined ##miniscript --- Log closed Mon Jan 04 00:00:06 2021