--- Log opened Thu Jan 14 00:00:14 2021
01:24 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds]
01:26 -!- jonatack [~jon@185.206.225.51] has joined ##miniscript
01:34 -!- jonatack [~jon@185.206.225.51] has quit [Quit: jonatack]
01:34 -!- jonatack [~jon@185.206.225.51] has joined ##miniscript
04:40 -!- jonatack [~jon@185.206.225.51] has quit [Quit: jonatack]
04:49 -!- jonatack [~jon@88.124.242.136] has joined ##miniscript
04:54 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 246 seconds]
04:55 -!- jonatack [~jon@213.152.162.154] has joined ##miniscript
06:01 -!- jonatack [~jon@213.152.162.154] has quit [Ping timeout: 246 seconds]
06:26 -!- jonatack [~jon@88.124.242.136] has joined ##miniscript
06:31 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds]
07:08 -!- jonatack [~jon@79.142.69.160] has joined ##miniscript
07:13 -!- jonatack [~jon@79.142.69.160] has quit [Ping timeout: 246 seconds]
07:16 -!- jonatack [~jon@37.172.240.245] has joined ##miniscript
07:20 -!- jonatack [~jon@37.172.240.245] has quit [Read error: Connection reset by peer]
07:53 -!- shesek [~shesek@164.90.217.137] has joined ##miniscript
07:53 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
07:53 -!- shesek [~shesek@unaffiliated/shesek] has joined ##miniscript
08:36 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined ##miniscript
09:03 -!- jonatack [~jon@88.124.242.136] has joined ##miniscript
09:07 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds]
09:09 -!- jonatack [~jon@213.152.162.74] has joined ##miniscript
09:39 < dr-orlovsky> andytoshi: what about having on 4.0.4 release adopting bitcoin 0.26 with no other changes (meaning it will fork from a 4.0.3 release commit)?
09:41 < andytoshi> using bitcoin 0.26 is a breaking change
09:50 < andytoshi> sanket1729: sanketcell: around? gonna do a 0.26 PR
09:55 < dr-orlovsky> andytoshi: not sure I get why it's a breaking change if you don't re-export it...
09:55 < andytoshi> we do re-export it, both directly and in almost every single function signature 
09:55 < andytoshi> anything that takes or returns a PublicKey or a Script or a Signature depends on rust-bicoin
09:56 < dr-orlovsky> andytoshi: if you are busy I can work on 0.26 PR since I need miniscript to be updated in order to use it alongside rust-bitcoin 0.26
09:56 < andytoshi> no, i've already done it, i'm just writing the changelaog
09:56 < andytoshi> gimme 5
10:00 < andytoshi> https://github.com/rust-bitcoin/rust-miniscript/pull/225
10:04 < dr-orlovsky> I have a bunch of WIPs on miniscript down the line which may be breaking changes. Will you be ok with doing 6.0 release soon (~month from now)?
10:05 < dr-orlovsky> (being a bit afraid of number going up such quickly :)
10:05 < andytoshi> lol sure
10:05 < andytoshi> yeah, i think we've bitten the bullet about making the number go up fast
10:06 < andytoshi> because we'll also have a ton of breakage for taproot, and probably more breakage as we tool around on elements-miniscript, and i'm sure the DescriptorPublicKey API still isn't really where we want it
10:08 < dr-orlovsky> "DescriptorPublicKey API still isn't really where we want it" - can't agree more :) Was not able to use it in practice and did my own type instead :(
10:10 < andytoshi> i added a bunch of stuff to it in this release fwiw
10:10 < andytoshi> and PRs are welcome to improve the API
10:31 < sanket1729> yes
10:31 < sanket1729> reviewing now
11:20 < sanket1729> Nice, I can finally work on the intergration test and dmitry's test vectors for miniscript. 
11:20 < sanket1729> andytoshi: I should presume that you have already done all your local checks for the pr you propose?
11:22 < sanket1729> And I can merge those if there are ACKs
11:26 < andytoshi> sanket1729: well, no, i have to tool around on my local checks a bit.. but i think it's ok to just merge this one
11:27 < sanket1729> should we also get 224 in. It's a 4 word diff :P
11:28 < andytoshi> lol, yeah, lemme just run my old local checks on it
11:28 < dr-orlovsky> andytoshi: is there any chance to get https://github.com/rust-bitcoin/rust-miniscript/pull/224/files into rust-miniscript 5.0? It's ultra-trivial
11:28 -!- harding [~quassel@newmail.dtrt.org] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
11:28 < andytoshi> dr-orlovsky: sure, gimme 10 mins
11:28 < andytoshi> i just need to fuzz it
11:29 -!- harding [~quassel@newmail.dtrt.org] has joined ##miniscript
11:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
11:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined ##miniscript
11:33 < andytoshi> ok 224 is in
11:33 < andytoshi> gimme 5 to test 225 and then i'll release
11:38 < andytoshi> ok 5.0 published
11:38 < dr-orlovsky> thank you!
12:08 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined ##miniscript
12:08 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
13:12 < dr-orlovsky> why you have removed DescriptorPubkeyCtx in 5.0? What is the API for now if I need to derive child keys since my MiniscriptKey is an extended key?
13:16 < andytoshi> use translate_pk
13:16 < andytoshi> or .derive()
13:17 < andytoshi> and DescriptorPubkeyCtx was removed becasue it didn't work
13:17 < andytoshi> it made the API a zillion times as complicated and you'd still panic everywhere if you had hardened paths anywhere
13:19 < andytoshi> see e.g. https://github.com/apoelstra/icebox/blob/descriptors/src/lib/wallet/mod.rs#L351-L357 ... this creates a CachedKey which is an icboc-specific thing
13:19 < andytoshi> but the output of .derive is a bitcoin::PublicKEy
13:19 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
13:30 -!- felixweis [sid154231@gateway/web/irccloud.com/x-ammtqmswwvkhmxzx] has quit [Ping timeout: 260 seconds]
13:30 -!- felixweis [sid154231@gateway/web/irccloud.com/x-mdptrwlrtlphtxkd] has joined ##miniscript
14:57 < sanket1729> when using translate_pk, I am having some funny rust error
14:57 < sanket1729> https://gist.github.com/sanket1729/70f9c09ec4e0f44923bd707dd16d8495
14:58 < sanket1729> any ideas, what is going on here
15:21 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined ##miniscript
16:03 -!- Netsplit *.net <-> *.split quits: kallewoof, jonatack, schmidty, harrigan, elichai2, felixweis, windsok
16:03 < andytoshi> https://github.com/rust-lang/rust/issues/79187#issuecomment-759106084
16:04 < andytoshi> if you add some explicit lifetime annotations that should work around it
16:04 < andytoshi> or explicit &s
16:04 < andytoshi> or something
16:05 -!- Netsplit over, joins: felixweis, windsok, elichai2, schmidty, kallewoof
16:06 -!- Netsplit over, joins: jonatack, harrigan
16:06 < sanket1729> nice. That did the trick
16:07 < sanket1729> adding explicit lifetime annotations. 
16:07 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-kmxptbegweexrioe] has quit [Ping timeout: 264 seconds]
16:09 -!- schmidty [sid297174@gateway/web/irccloud.com/x-pilbrnsjaokvmwfz] has quit [Ping timeout: 274 seconds]
16:09 -!- schmidty [sid297174@gateway/web/irccloud.com/x-bcmslhjuomznedcf] has joined ##miniscript
16:10 -!- martindale [ericfabric@gateway/shell/matrix.org/x-gpriizjdtgudkysf] has quit [Ping timeout: 268 seconds]
16:12 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-lrklepokwofiibml] has joined ##miniscript
16:32 < dr-orlovsky> > andytoshi: it made the API a zillion times as complicated and you'd still panic everywhere if you had hardened paths anywhere
16:34 < dr-orlovsky> yeah, noticed that. Spent a day adopting miniscript 4.0.0 in a library & software totalling to >100k lines of rust code :) Now will spend another few days migrating 5.0 :)
16:34 < dr-orlovsky> In fact I eded up duplicating all structures like DescriptorPublicKeu with my own (and also developing alternative BIP32 implementation, which does not panic)
16:34 < andytoshi> oof sorry :)
16:34 < sanket1729> sorrry about that. ToPkCtx was big mistake
16:34 < dr-orlovsky> now need to re-think it over a new version
16:35 < andytoshi> yeah, i also wound up needing a parallel data structure .. but it should be much much easier now
16:35 < dr-orlovsky> don't be sorry, it's experiments
16:35 < dr-orlovsky> I will try to summarize what I came up with and present it somehow - may be some parts of it may be appropriate for rust-miniscript
16:36 < andytoshi> nice, looking forward :)
16:37 < dr-orlovsky> was giving small presentation about this stuff yesterday: https://github.com/LNP-BP/FAQ/blob/master/Presentation%20slides/LNP:BP%20Core%20Library%20%E2%80%93%20BP%20module.pdf
16:39 < dr-orlovsky> my current experience of applying miniscript & descriptors (+BIP) to a pure bitcoin transactions on-chain comes from this case: https://github.com/pandoracore/bitcoin-pro
16:41 < dr-orlovsky> specifically, this soft does not have access to any private keys ever, so this is a good testing case for stuff like derivation when you have no (extended) private keys and need to monitor descriptors/blockchain for complex (mini)scripts and beyond
16:46 < andytoshi> nice. lol i'm amazed you pulled that off with the old API
16:49 < dr-orlovsky> mostly it was done with a custom type system around the old API
16:50 < dr-orlovsky> feel free to look into these two files and pick any types you like - I will make them as a PRs to either rust-bitcoin or rust-miniscript:
16:50 < dr-orlovsky> 1) https://github.com/LNP-BP/rust-lnpbp/blob/master/src/bp/bip32.rs
16:50 < dr-orlovsky> 2) https://github.com/LNP-BP/rust-lnpbp/blob/master/src/bp/descriptor.rs
17:01 -!- martindale [ericfabric@gateway/shell/matrix.org/x-krwyremnukehppvk] has joined ##miniscript
19:01 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 260 seconds]
19:39 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined ##miniscript
21:29 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
21:29 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined ##miniscript
22:19 -!- notmandatory [~notmandat@shindig.notmandatory.org] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
22:21 -!- notmandatory [~notmandat@shindig.notmandatory.org] has joined ##miniscript
22:36 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
--- Log closed Fri Jan 15 00:00:15 2021