--- Log opened Thu Jan 21 00:00:24 2021
00:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
00:35 -!- shesek [~shesek@164.90.217.137] has joined ##miniscript
00:35 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
00:35 -!- shesek [~shesek@unaffiliated/shesek] has joined ##miniscript
07:20 -!- martindale [ericfabric@gateway/shell/matrix.org/x-cuzfqrxjlsikssmb] has quit [Quit: Bridge terminating on SIGTERM]
07:30 -!- martindale [ericfabric@gateway/shell/matrix.org/x-udhfdpqibunsnusq] has joined ##miniscript
08:50 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined ##miniscript
14:48 -!- roconnor [~roconnor@host-45-58-196-78.dyn.295.ca] has joined ##miniscript
15:19 -!- roconnor [~roconnor@host-45-58-196-78.dyn.295.ca] has quit [Ping timeout: 265 seconds]
16:41 -!- Netsplit *.net <-> *.split quits: ghost43, jb55
16:58 -!- Netsplit over, joins: jb55
16:59 -!- Netsplit over, joins: ghost43
17:55 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
19:02 < shesek> it looks like the rust-miniscript v0.5 release didn't get tagged
19:02 < andytoshi> maybe i forgot to push it
19:03 < andytoshi> hmm git push --tags says up to date
19:03 < andytoshi> 5.0.0 is tagged
19:03 < andytoshi> as is 0.5.0
19:04 < shesek> its not showing up on https://github.com/rust-bitcoin/rust-miniscript/tags
19:04 < shesek> nor on the branch/tag switcher on the top left
19:04 < andytoshi> hmmm
19:05 < andytoshi> ohh i messed up my github remotes, one sec
19:06 < andytoshi> ok should be good now
19:06 < andytoshi> i was pushing to apoelstra/rust-minsicritp not rust-bitcoin/miniscript
19:06 < shesek> nice, thank you
19:06 < shesek> may I also ask for a peek at https://github.com/rust-bitcoin/rust-miniscript/pull/228?
19:07 < andytoshi> yeah, sorry, i'll try to do it tomorrow morning
19:07 < andytoshi> been writing a blog post, it's taking a lot of eneregy
19:07 < shesek> I already upgraded my code to rust-miniscript 0.5 and rust-bitcoin 0.26, and now can't release until its fixed. :(
19:07 < shesek> awesome, thank you
19:07 < andytoshi> hehe ok lemme review it now
19:08 < shesek> its not that urgent, can definitely wait until tomorrow :)
19:08 < andytoshi> nah well i'm just gonna leave it to the evening and then go "oh shit" tomorrow
19:08 < andytoshi> so i might as well do that now
19:08 < andytoshi> :P
19:08 < andytoshi> running CI ... next commercial break in the hockey game i'll read the code
19:09 < shesek> appreciated, enjoy the game
19:13 < andytoshi> shesek: want to add a commit bumping to 5.1, or 5.0.1 or whatever
19:13 < andytoshi> or i can do it in a separate PR
19:13 < andytoshi> but you'll have to wait for the next commercial :P
19:14 < sanket1729> andytoshi: I also a couple PRs about satisfaction logic
19:14 < sanket1729> let me push them
19:14 < andytoshi> kk
19:14 < andytoshi> i'll just merge 228 then?
19:14 < sanket1729> 5 line diffs should be easy to review
19:14 < sanket1729> yeah
19:14 < andytoshi> done
19:15 < shesek> andytoshi, re your GH comment, some of these string allocations are needed for computing the checksum
19:15 < andytoshi> shesek: ah, ok, that makes sense
19:15 < andytoshi> we have similar stuff in base58ck code in rust-bitcoin
19:16 < shesek> should I bump to 5.0.1 or will you do it separately because there are other PRs too?
19:16 < andytoshi> which i was actually just thinking about as i fell asleep last night, we could serialize stuff directly into a hash engine there
19:16 < andytoshi> but i don't think we can write our own fmt::Formatter to do something similar
19:17 < andytoshi> without a lot of annoying ergonomic pain
19:20 < andytoshi> hmm "dissatisfactions don't need to be nonmalleable"
19:20 < andytoshi> i'm curious if that change ever has any effect
19:20 < sanket1729> yes it does
19:21 < andytoshi> then i'm curious whether it's actually correc t:P
19:21 < sanket1729> for example when trying to satisfy a miniscrpit which requires orI dissatifsaction
19:21 < sanket1729> both of the available dissats for OI are malleable
19:21 < sanket1729> Our current code would fail.
19:21 < andytoshi> right .. i think that script is just impossible to handle nonmalleably
19:21 < andytoshi> i think failing is the rigt thing
19:22 < sanket1729> Oh, right. 
19:22 < sanket1729> duh
19:22 < andytoshi> :P
19:24 < sanket1729> shesek: I can create a 5.0.1 bump in this PR
19:24 < andytoshi> +1
19:26 < andytoshi> ok just waiting on my scripts to run
20:09 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined ##miniscript
--- Log closed Fri Jan 22 00:00:24 2021