--- Log opened Mon May 24 00:00:04 2021 02:56 -!- jnewbery_ [~john@89.197.152.162] has joined ##miniscript 03:01 -!- jnewbery_ [~john@89.197.152.162] has quit [Client Quit] 03:11 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 240 seconds] 03:11 -!- jnewbery [~john@164.90.178.190] has quit [Quit: leaving] 03:11 -!- jnewbery [~john@164.90.178.190] has joined ##miniscript 03:12 -!- jnewbery [~john@164.90.178.190] has quit [Client Quit] 03:12 -!- jnewbery [~john@164.90.178.190] has joined ##miniscript 03:14 -!- jnewbery_ [~john@89.197.152.162] has joined ##miniscript 03:17 -!- queip [~queip@unaffiliated/rezurus] has joined ##miniscript 03:18 -!- jnewbery_ [~john@89.197.152.162] has quit [Client Quit] 03:19 -!- jnewbery_ [~john@89.197.152.162] has joined ##miniscript 03:25 -!- jnewbery [~john@164.90.178.190] has quit [Quit: leaving] 03:25 -!- jnewbery [~john@164.90.178.190] has joined ##miniscript 03:32 -!- jnewbery [~john@164.90.178.190] has quit [Quit: leaving] 03:32 -!- jnewbery [~john@164.90.178.190] has joined ##miniscript 04:03 -!- jnewbery_ [~john@89.197.152.162] has quit [Quit: leaving] 09:46 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined ##miniscript 09:49 < sipa> any comments on adding the tr() descriptor as implememted im https://github.com/bitcoin/bitcoin/pull/21365 ? 09:49 < sipa> summary: add top level fragments tr(KEY) and tr(KEY,TREE) for key-only and key+script respectively 09:50 < sipa> a TREE is either a KEY, or {TREE,TREE} 09:50 < sipa> eh, a SCRIPT or {TREE,TREE} 09:50 < jeremyrubin> is there a reason for "{ 09:50 < jeremyrubin> vs '(' 09:51 < sipa> and KEY expressions in tr or in scripts beneath it can be all the usual key expressions (incl. compressed hex), plus xonly hex 09:51 < sipa> jeremyrubin: eh, i think of () as function application, while this is more a data structure being enumerated 09:51 < sipa> no strong opinion, but i think it's slightly clearer 09:52 < jeremyrubin> i see; my only feedback is that it seems NEWICK is a popular format https://en.wikipedia.org/wiki/Newick_format and it uses ( 09:53 < sipa> yeah, i saw that 09:53 < jeremyrubin> so might be easier to find some widgets to display descriptors if we ever want that 09:53 < sipa> that seems like an extreme niche thing 09:53 < sipa> i had never heard about it, and converting is still trivial 09:54 < gwillen> sipa: I have no particular comments, but I read through it and it makes sense to me. 09:54 < jeremyrubin> i forget where, but it was requested of me for github.com/sapio-lang/tux to graphically show what the descriptor is 09:54 < sipa> (and maybe easier, actually? because if it all uses () you need an actual parser to separate the tree stuff from the rest of descriptors?) 09:57 < jeremyrubin> yeah not a huge deal either way -- it was the only format I could turn up when i searched standard tree formats 09:57 < jeremyrubin> and it should be regex replacable anyways 09:58 < jeremyrubin> but the nice thing is it does have a defined spec for where to add annotations and the like, so could save some bikeshedding down the line if such things are needed in the future 10:01 < sipa> jeremyrubin: i think that's perhaps a choice that could have made for the descriptor language overall, but i feel that trying to add that now for these subexpressions would lead us too far 12:30 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 16:44 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 16:44 -!- shesek [~shesek@164.90.217.137] has joined ##miniscript 16:44 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 16:44 -!- shesek [~shesek@unaffiliated/shesek] has joined ##miniscript 18:05 -!- Netsplit *.net <-> *.split quits: jnewbery, shesek 18:15 -!- Netsplit over, joins: shesek, jnewbery 18:50 < darosior> sanket1729: when you have a sec, would love feedback on https://github.com/sipa/miniscript/pull/55 :) 18:51 < sanket1729> darosior: I was reviewing it yesterday. I think I found some unrelated bug, got deep into investigating it. Reviewing now --- Log closed Tue May 25 00:00:05 2021