--- Log opened Wed Jun 16 00:00:39 2021
00:11 -!- kallewoof is now known as kalle
03:37 -!- jnewbery_ is now known as jnewbery
04:46 < darosior> I was implementing some missing checks for timelocks values in the Rust implem, and i wondered if we'd like to check too that the time value is "miminal". That is that `(t & LOCKTIME_MASK) == t`, fwiw that's what i do downstream https://github.com/revault/revault_tx/blob/6a0c2759332e4674e7a1f288241b0a546422d4f5/src/scripts.rs#L145-L151
09:44 <@sanket1729> darosior: I am not sure if want to check the minimality, but we should check that it is not disabled. 
09:45 < darosior> sanket1729: but non-minimality induces malleability?
09:45 <@sanket1729> It is signed
09:45 < darosior> Oh right
09:45 <@sanket1729> nsequence is signed
09:45 < darosior> Right
09:46 < darosior> :)
10:31 < darosior> sipa: why checking that the timelock is < 0x80000000 even for CLTV? https://github.com/sipa/miniscript/blob/f7de269be2f3c8e314cf26dd331d46930e076c31/bitcoin/script/miniscript.cpp#L46-L47
10:40 <@sanket1729> darosior: Ah, I remember. The reason is quite involved. The B type in miniscript assumes atmost 4 bytes. scriptints >= 2^31 take 5 bytes on stack
10:40 < darosior> Ah!
10:40 <@sipa> right!
10:42 < darosior> Ok, thanks, because i suspected signed integers at first but then CLTV makes CScriptNum take 5 bytes. Guess i'll revert the change i just pushed now :)
22:41 -!- roconnor [~roconnor@host-184-164-16-124.dyn.295.ca] has quit [Ping timeout: 268 seconds]
--- Log closed Thu Jun 17 00:00:40 2021