--- Log opened Wed Jul 28 00:00:22 2021 10:50 < sanket1729> andytoshi: can you look at andytoshi: can you look at https://github.com/rust-bitcoin/rust-miniscript/pull/257?? 10:51 < sanket1729> This should fix the CI so that we can have a nice green check :P on the release PR 14:37 <@andytoshi> lol why did we give these enums names that don't match the spec 14:38 <@andytoshi> what are AnyNonZero and OneNonZero? 14:38 <@andytoshi> and Zero? 14:50 < sanket1729> haha 14:51 < sanket1729> Look at the display function for Terminal to see how it maps to the types 14:52 < sanket1729> Because we wanted to maintain invariants between the type names 15:14 <@andytoshi> ok, i might have time later today to do that 15:38 < sanket1729> Yeah, in retrospect it's hard to understand it 15:39 < sanket1729> Note to self: Use same variable names as spec to avoid these issues in future. --- Log closed Thu Jul 29 00:00:22 2021