--- Log opened Tue Aug 24 00:00:48 2021
06:24 -!- Netsplit *.net <-> *.split quits: sanket1729, andytosh1
06:28 -!- andytosh1 [~apoelstra@s66-183-0-205.bc.hsia.telus.net] has joined ##miniscript
06:28 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined ##miniscript
07:32 -!- muhblockchain [~muhblockc@user/muhblockchain] has joined ##miniscript
10:57 < darosior> FWIW i opened https://github.com/darosior/bitcoin/pull/2 to get things rolling. It's a rebased version of https://github.com/bitcoin/bitcoin/pull/16800 with the latest Miniscript changes included, as well as the PR from the miniscript repo which i deemed were likely to be merged before the PR. Even if more changes are needed it should be trivial to
10:57 < darosior> keep https://github.com/darosior/bitcoin/pull/2 in sync now. Planning to add a fuzz target soon, too.
10:57 < darosior> Of course the branch is not yet polished
11:08 <@sipa> but is it... reverse polished?
11:09 <@sipa> darosior: was it hard tor ebase?
11:10 < darosior> Not that much, just had to take care to split well each part between each commit
11:11 < darosior> Also learned that your Bitcoin Core PR didn't have the satisfier yet!
11:18 < darosior> The rebase was largely made easier thanks to sanket1729's https://github.com/sipa/miniscript/pull/58
11:34 < sanket1729> darosior: Thanks for this. I had a relatively old version https://github.com/sanket1729/bitcoin/pull/2 which can now be closed
11:34 < sanket1729> We can continue on the darosior/bitcoin. I think the initial plan was just to add miniscript descriptors without any signing
11:36 -!- andytosh1 is now known as andytoshi
11:47 < sanket1729> darosior: About the master fingerprint PR. I think we should take the first 4 bytes
11:58 < sanket1729> andytoshi: The Taproot context PR https://github.com/rust-bitcoin/rust-miniscript/pull/255
11:59 < sanket1729> ^ also for darosior if you have time for review
12:15 < andytoshi> thanks sanket1729 
12:15 < andytoshi> i will be free in about an hour :)
12:15 < andytoshi> which i know i said 3 hours ago..
12:47 < darosior> sanket1729: heading a conference but will try to have a look!
13:21 < andytoshi> sorry, i lied, i have to run some errands now
15:19 < meshcollider> darosior: sorry we may have duplicated effort, I already have a rebased branch here which I mentioned in one of the PRs 😅 https://github.com/meshcollider/bitcoin/tree/202108_miniscript
15:20 < meshcollider> But we need to wait for the Parse and Decode non-recursive changes first
15:24 < meshcollider> (this version has no signing)
15:27 < meshcollider> I'm happy to maintain this branch too
15:34 < meshcollider> sipa: have you had a chance to think more about how your generic non-recursive functions will work btw? Otherwise I could work on a non-generic version of Decode*() and see how it turns out
16:49 < andytoshi> sanket1729: ok, i've gone over 255. thanks for this! i left a bunch of comments, a couple of them are potentially big API changes
16:59 <@sipa> meshcollider: i've thought a lot about it, but not written a line of code :)
17:03 < meshcollider> sipa: I can try and write some code if you want to talk me through the idea further :) Up to you though
17:23 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Quit: Reconnecting]
17:23 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined ##miniscript
17:25 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Client Quit]
17:25 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined ##miniscript
17:44 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Quit: Reconnecting]
17:44 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined ##miniscript
22:21 < darosior> meshcollider: oh! i thought you had left it to Sanket since he already did it before
23:18 < meshcollider> darosior: actually I didn't even realise Sanket had because no-one had mentioned it on #16800 😅  So I just messaged Pieter and he said to come and discuss here :)
23:18 < meshcollider> and now because of the recursion issues I think we should fix those first
23:20 < meshcollider> apologies for the lack of communication on my part
23:32 < darosior> meshcollider: no worries, just that Sanket and i have been working on that for some time now. I think we should deduplicate efforts and concentrate on https://github.com/darosior/bitcoin/pull/2 if you don't mind?
--- Log closed Wed Aug 25 00:00:49 2021