--- Log opened Wed Aug 25 00:00:49 2021
00:24 < sanket1729> I think we resolve everything on sipa/miniscript first. 
00:24 < sanket1729> In particular, timelock stuff, and the non-recursive parsing/decoding.
00:34 < darosior> Yeah, of course
00:40 < meshcollider> darosior: okay, do you want to cherry-pick the commits from my branch to remove the signing bit from yours then?
00:41 < sanket1729> meshcollider: I think the current implementation of Parse (as well the implementation from meshcollider) is quite inefficient as it calls Expr() multiple times.
00:42 < sanket1729> Expr efficiently reads the entire array
00:43 < sanket1729> And we can calling it again on sub-expressions re-reading the same data again
00:45 < sanket1729> Handwavingly, I _think_ this is quadratic time for thresh(1,thresh(1,....) . 
00:47 < sanket1729> I think we can do a linear time maintaining some sort of depth first search type thing using stack.  
00:50 < sanket1729> I should really first try this out, but I think we should be able to parse non-recursively in linear time. 
00:50 < meshcollider> Yeah you're right, definitely think it can be done for Parse
00:50 < meshcollider> Decode is a bit more challenging
00:51 < meshcollider> I have been working on a non-recursive version but haven't quite finished yet
00:52 < sanket1729> The decode implementation andytoshi has in rust-miniscript is non-recursive. 
00:56 < meshcollider> ooh cool, I'll check that out!
00:56 < meshcollider> maybe I can c++'ify it
00:57 < sanket1729> https://github.com/rust-bitcoin/rust-miniscript/blob/master/src/miniscript/decode.rs . It is full of macros, so might be hard to read. 
04:28 -!- blkncd [sid505676@2001:67c:2f08:5::7:b74c] has quit []
04:28 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has joined ##miniscript
13:08 -!- meshcollider [meshcollid@user/meshcollider] has quit [Remote host closed the connection]
13:31 -!- meshcollider [meshcollid@jujube.ircnow.org] has joined ##miniscript
14:36 -!- meshcollider [meshcollid@jujube.ircnow.org] has quit [Changing host]
14:36 -!- meshcollider [meshcollid@user/meshcollider] has joined ##miniscript
--- Log closed Thu Aug 26 00:00:49 2021