--- Log opened Mon Nov 15 00:00:34 2021 02:46 -!- meshcollider [meshcollid@user/meshcollider] has quit [Ping timeout: 268 seconds] 02:49 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has joined ##miniscript 03:44 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has quit [Changing host] 03:44 -!- meshcollider [meshcollid@user/meshcollider] has joined ##miniscript 07:04 -!- roconnor [~roconnor@host-45-58-217-8.dyn.295.ca] has quit [Remote host closed the connection] 07:34 -!- roconnor [~roconnor@host-45-58-217-8.dyn.295.ca] has joined ##miniscript 07:54 -!- elsirion_ [~quassel@gateway/tor-sasl/elsirion] has quit [Remote host closed the connection] 07:54 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined ##miniscript 08:48 -!- gene is now known as annoyingbritishc 08:48 -!- annoyingbritishc is now known as gene 09:19 < sanket1729_> jeremyrubin: Thanks, taking a look at it 09:39 < jeremyrubin> do you have a preference on the saturating v.s. + and using u128/u64 vs u64/u32? 09:45 < sanket1729_> Nah, I leave it to your preference 09:50 < jeremyrubin> i'll just do it as a a follow up PR open for discussion but probably best to make the API change bikeshed separate from bugfix (my bad, I was just doing my follow up post-merge reviews when i noticed the bug on the other pr) 09:51 < jeremyrubin> i think we're OK to go to u32/u64 since the earlier type there was a usize, and 2**32:1 should be enough relative odds for almost anything i can think of? 09:51 < jeremyrubin> In fact i'd even be ok with u16 there, but there's no point to 09:52 < jeremyrubin> "this branch is 60,000X more likely than that one" seems like a rare ocurrence" 09:54 < sanket1729_> Agreed, `u32` should be good for all use-cases. 15:51 -!- roconnor [~roconnor@host-45-58-217-8.dyn.295.ca] has quit [Quit: Konversation terminated!] 18:35 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Ping timeout: 276 seconds] 23:36 -!- kallewoof [~quassel@user/kallewoof] has joined ##miniscript 23:57 -!- MatrixBot1234510 [~matrixbot@51.15.54.153] has quit [Quit: Bridge terminating on SIGTERM] --- Log closed Tue Nov 16 00:00:34 2021