--- Log opened Tue Dec 07 00:00:54 2021
06:55 < darosior> sipa: re https://github.com/sipa/miniscript/pull/78#discussion_r762581004 (having multiple dummy keys / hashes / etc in the KeyConverter for the fuzz target), what do you mean by "testing that used keys/etc match"? Testing the satisfier took the expected path? Regarding the fuzzing against VerifyScript, i was just expecting that we'd
06:55 < darosior> ProduceSignature() with a dummy checker for signatures, hashes and timelocks challenges
06:59 < darosior> I should probably just implement that now that i have the signing support and come back after.
07:00 <@sipa> darosior: say the fuzz-constructed script is (equivalent to) and_b(pk(),pk())
07:00 <@sipa> dummy signing will nicely test that the constructed witness matches the script structure
07:01 <@sipa> but if the fuzzer could construct something like and_b(pk(A),pk(B)), with dummy verifier that has fixed signatures sigA (valid for pk(A)) and sigB (valid for pk(B)), it could additionally test that it puts the signature for the right key in the right place
07:02 < darosior> Makes sense
07:04 < darosior> Relatedly for dummy checker i had to make the OP_EQUAL check in the interpreter part of BaseSignatureChecker. I would rather not touch consensus code but all other options to make Miniscript descriptors with hash checks IsSolvable() were way uglier..
07:06 <@sipa> what OP_EQUAL?
07:07 < darosior> SIZE <32> EQUALVERIFY SHA256 <h> EQUAL
07:09 <@sipa> i think hash checks should just always be treated as IsSolvable
07:09 <@sipa> they're in a way private keys (just symmetric ones), and IsSolvable means "could I sign if I had all the key data"
07:10 < darosior> I agree but then you need to pass VerifyScript() (with the dummy checker) for being IsSolvable()
07:11 <@sipa> ah, i see
07:11 <@sipa> good pointy
07:11 <@sipa> -y
08:33 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
09:07 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
09:08 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
09:21 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
09:21 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
10:03 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
10:04 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
10:28 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Ping timeout: 276 seconds]
10:29 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
10:30 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
10:31 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
11:09 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
11:09 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
11:18 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
11:19 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
12:04 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
12:05 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
12:09 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
12:14 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
12:35 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
12:36 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
13:05 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
13:10 -!- gene [~gene@gateway/tor-sasl/gene] has joined ##miniscript
16:38 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
--- Log closed Wed Dec 08 00:00:55 2021