--- Log opened Sun Dec 19 00:00:05 2021
08:22 < darosior> FWIW the discrepancy between rust-miniscript and c++ Miniscript make this very hard to achieve, even the unit tests currently in my PR are invalid according to rust-miniscript IIRC.
08:25 <@sipa> What's invalid about them?
08:49 < darosior> iirc all the pkh() for instance
08:50 < darosior> Since rust-miniscript takes a hash in pk_h()
08:50 < darosior> Oh no actually i think rust-miniscript *allows* a hash, just that we are stricter
08:51 < darosior> But can take a pubkey as well
08:54 < darosior> So i was incorrect in saying that rust-miniscript wouldn't parse them. Still, not accepting the same set of inputs between the two implementations makes interop testing (slightly?) harder.
09:10 <@sipa> Right, they permit hashes for unknown keys.
09:16 <@sipa> If for tr() we're going to add support for unrevealed subtrees, it may make sense to permit pkh hashes too.
09:24 <@sipa> What syntax does it use for that? I worry it may be confusing with tr() accepting 64 hex characters as actual key, and pkh() 64 hex characters as key hash...
09:39 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye]
09:40 -!- achow101 [~achow101@user/achow101] has joined ##miniscript
13:28 -!- jeremyrubin [~jeremyrub@ec2-44-199-24-18.compute-1.amazonaws.com] has quit [Quit: The Lounge - https://thelounge.chat]
13:28 -!- jeremyrubin [~jeremyrub@ec2-44-199-24-18.compute-1.amazonaws.com] has joined ##miniscript
16:27 <@sipa> @darosior See https://github.com/sipa/miniscript/pull/83 for a non-recursive version of ToScript and ToString.
17:12 <@sipa> @meshcollider @sanket1729 You may be interested too.
22:35 < meshcollider> sipa: will review, but probably next year :p
--- Log closed Mon Dec 20 00:00:06 2021