--- Log opened Tue Feb 01 00:00:46 2022 00:27 < darosior> After the remaining PRs i don't think i'm going to keep the repo in sync with the PR while it's not merged. It's going to be too much work for everyone. Instead i'll PR an "update from Bitcoin Core" once/if it's merged to the Miniscript repo 01:31 -!- enick_919 [~afilini-m@2001:bc8:1828:245::2] has quit [Ping timeout: 240 seconds] 02:15 -!- midnight_ [~midnight@user/midnight] has joined ##miniscript 02:15 -!- midnight [~midnight@user/midnight] has quit [Ping timeout: 256 seconds] 03:33 -!- sipa [~sipa@user/sipa] has quit [Quit: Bridge terminating on SIGTERM] 03:33 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Quit: Bridge terminating on SIGTERM] 03:33 -!- ademan[m] [~ademanmat@2001:470:69fc:105::1:16db] has quit [Quit: Bridge terminating on SIGTERM] 03:33 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Quit: Bridge terminating on SIGTERM] 03:40 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined ##miniscript 03:47 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Remote host closed the connection] 04:00 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined ##miniscript 04:02 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Remote host closed the connection] 04:07 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined ##miniscript 04:20 -!- sipa [~sipa@user/sipa] has joined ##miniscript 04:20 -!- mode/##miniscript [+o sipa] by ChanServ 04:20 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined ##miniscript 04:20 -!- ademan[m] [~ademanmat@2001:470:69fc:105::1:16db] has joined ##miniscript 04:34 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Quit: Client limit exceeded: 20000] 04:36 -!- sipa [~sipa@user/sipa] has quit [Quit: Client limit exceeded: 20000] 04:39 -!- ademan[m] [~ademanmat@2001:470:69fc:105::1:16db] has quit [Quit: Client limit exceeded: 20000] 04:53 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Quit: Client limit exceeded: 20000] 05:20 -!- sipa [~sipa@user/sipa] has joined ##miniscript 05:20 -!- mode/##miniscript [+o sipa] by ChanServ 05:20 <@sipa> Yeah, I was going to suggest it would become too much work to keep up both. 06:11 -!- enick_142 [~afilini-m@2001:bc8:1828:245::2] has joined ##miniscript 06:56 < michaelfolkson> darosior: Just to be clear Core PRs will have the latest reviewable state right? And then when merged into Core the Miniscript repo will be updated? 06:56 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined ##miniscript 06:56 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined ##miniscript 06:56 -!- ademan[m] [~ademanmat@2001:470:69fc:105::1:16db] has joined ##miniscript 06:57 < darosior> Yeah it's what i'm planning to do 07:13 < michaelfolkson> Ok thanks 11:24 <@sipa> darosior: what's your strategy for merging the miniscript branch with bitcoin core now? is it just copying/overwriting the files? 11:25 < darosior> Depends on when the patches apply or not :/ 11:25 <@sipa> haha 11:26 <@sipa> Because if I'm going to try to substantially modify the fuzz test, I wouldn't want to need your help in figuring out whether it works every time... 11:27 < darosior> I can give you my WIP branch 11:27 <@sipa> I'll try taking your 3rd bitcoin core PR branch, and copying the current miniscript tree over into it 11:27 < darosior> (writing down my strategy) 11:28 < darosior> First i work on the signing branch (to have more chances to get the patches to apply, since it contains the satisfaction code). Then i try to keep the PRs to Miniscript rebased on each other so the patches apply more often (since they pile up on the core PR branch, although i could use one fork per PR but hey). Finally if nothing works out i copy 11:28 < darosior> the file over in one way or another and use `git checkout -p -- src/script/miniscript.{h/cpp}` to remove the noise 11:30 < darosior> This branch is the 3rd PR (signing) with all the latest merged PRs applied (but your nit PR), as well as the fuzz target: https://github.com/darosior/bitcoin/tree/wip_miniscript_wallet_signing 11:30 <@sipa> ah, great, i'll rebase that on the nit PR, and work on that 11:31 <@sipa> actually, the nit doesn't interact 14:15 <@sipa> Do we not have any upper bound on the number of subexpressions in thresh()? 14:16 <@sipa> 200 would be a reasonable limit, as above that you're automatically going to hit the max non-push ops limit 15:33 -!- andytosh1 is now known as andytoshi 19:27 -!- enick_142 [~afilini-m@2001:bc8:1828:245::2] has quit [Ping timeout: 252 seconds] 21:39 -!- Netsplit *.net <-> *.split quits: paairs, fjahr, achow101, blkncd, elsirion, darosior, hugohn, michaelfolkson, sanket1729, ademan[m], (+11 more, use /NETSPLIT to show all of them) 21:51 -!- Netsplit *.net <-> *.split quits: roconnor, notmandatory_, sebx2a, FelixWeis 21:52 -!- ademan[m] [~ademanmat@2001:470:69fc:105::1:16db] has joined ##miniscript 21:52 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined ##miniscript 21:52 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined ##miniscript 21:52 -!- sipa [~sipa@user/sipa] has joined ##miniscript 21:52 -!- midnight_ [~midnight@user/midnight] has joined ##miniscript 21:52 -!- darosior [~darosior@194.36.189.246] has joined ##miniscript 21:52 -!- michaelfolkson [~michaelfo@138.68.143.20] has joined ##miniscript 21:52 -!- _aj_ [aj@user/aj/x-5857768] has joined ##miniscript 21:52 -!- andytoshi [~apoelstra@user/andytoshi] has joined ##miniscript 21:52 -!- sandipndev [sandipndev@2600:3c00::f03c:92ff:fe8e:dce6] has joined ##miniscript 21:52 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined ##miniscript 21:52 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined ##miniscript 21:52 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has joined ##miniscript 21:52 -!- MatrixBot12 [~matrixbot@2001:bc8:1828:379::1] has joined ##miniscript 21:52 -!- dr-orlovsky [~dr-orlovs@31.14.40.18] has joined ##miniscript 21:52 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined ##miniscript 21:52 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has joined ##miniscript 21:52 -!- _0x0ff [~0x0ff@user/0x0ff/x-0302470] has joined ##miniscript 21:52 -!- paairs [~rabidus@user/paairs] has joined ##miniscript 21:52 -!- achow101 [~achow101@user/achow101] has joined ##miniscript 21:52 -!- hugohn [sid304114@id-304114.lymington.irccloud.com] has joined ##miniscript 21:52 -!- ServerMode/##miniscript [+o sipa] by molybdenum.libera.chat 21:53 -!- Netsplit over, joins: sebx2a 21:53 -!- Netsplit over, joins: roconnor 21:54 -!- FelixWeis [sid154231@id-154231.hampstead.irccloud.com] has joined ##miniscript 21:54 -!- notmandatory_ [notmandato@2600:3c00::f03c:92ff:fe8e:dce6] has joined ##miniscript --- Log closed Wed Feb 02 00:00:48 2022