--- Log opened Tue Feb 08 00:00:53 2022 01:06 < darosior> sipa: Nice. What we can do is i update the fuzz target with your non-recursive version, and use it without the signing part for the first PR. The signing logic is only included in the 3rd PR so we have time to perfection the fuzz target against Verify(), and also do your simplification if that's successful. 01:07 < darosior> If you agree, what version of the miniscrip_random fuzz target can i use? The one on your random_fuzz branch? 05:04 <@sipa> You can use the final version of my branch without any signing code. I think that works. 06:17 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Quit: No Ping reply in 180 seconds.] 06:19 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined ##miniscript 07:02 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Remote host closed the connection] 07:02 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined ##miniscript 11:19 < andytoshi> sanket1729: this is a dumb question but why is Pk a type parameter everywhere in rust-miniscript, instead of being an associated type? 11:23 < andytoshi> it needs to be a parameter on the concrete types (nothing else makes sense) but the `Descriptor` trait and `Liftable` traits etc could take it as an associated type, and simplify a bunch of stuff 11:23 < andytoshi> i think 11:28 < andytoshi> sanket1729: als, just finished reviewing 278. looks great! 12:17 < sanket1729> andytoshi: I don't follow. Associated types are unique to a `impl struct`. We want to impl DescriptorTrait for Wsh, Wsh and so on 12:17 < sanket1729> Looking at the comments 12:18 < andytoshi> sanket1729: my question is, why does DescriptorTrait itself have Pk as a parameter? 12:19 < andytoshi> rather than an associated type 12:28 < sanket1729> Oh, I remember 12:28 < sanket1729> Because rust does not have support for associated generic types yet 12:31 < andytoshi> ah! lol ok 12:31 < andytoshi> man, rust's type system is really brutal ... it looks so much like it can do stuff, and lets you write so much code assuming it can do stuff .. and then fucks you 12:34 <@sipa> c++'s type system with templating is really just macros in disguise 12:34 <@sipa> advantage: it's hard to find things it can't do 12:34 <@sipa> disadvantage: it will be horrible 12:42 < andytoshi> `lol! 12:43 < andytoshi> i do find myself jealous of C++ from time to time --- Log closed Wed Feb 09 00:00:54 2022