--- Log opened Fri Feb 11 00:00:56 2022 01:00 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Quit: You have been kicked for being idle] 01:10 < darosior> So on Miniscript decoding from Script i think we still need a sanity check on the Script size. Currently i get a lot of OOMs on the (reworked) miniscript_decode target because AND_V decoding is still recursive and i'm not sure this can be worked around. 01:35 < sanket1729> Is it recursive? 01:36 < sanket1729> I don't follow 01:36 < darosior> My bad 01:36 < darosior> https://github.com/bitcoin/bitcoin/pull/24147#discussion_r804485876 01:37 < darosior> re recursivity of MAYBE_AND_V: https://github.com/sipa/miniscript/blob/dfe9d456ebdf4e9fccbe277abaa60d5ca645f82e/bitcoin/script/miniscript.h#L1426-L1430 01:40 < sanket1729> But the recursion fragments are on heap. And not implicit function stack 01:42 < darosior> Yeah to be explicit why i linked to the PR comment: it was only a consequence of making a mistake in patching the decoding function. Sorry for the noise! 01:43 < sanket1729> Btw, great work and thanks for the PR. I am doing a detailed review of the PR again. Comparing line by line to rust-miniscript 01:45 < darosior> Awesome 03:04 -!- rish [~rish@218.185.248.66] has joined ##miniscript 03:22 -!- rish [~rish@218.185.248.66] has quit [Quit: Client closed] 05:39 < andytoshi> wow, thanks sanket! 17:17 < sanket1729> andytoshi: Can you lookup https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/viewing-people-with-access-to-your-repository#exporting-a-list-of-people-with-access-to-your-repository and share somewhere? 17:17 < sanket1729> context: email from tobin about maintainers of different rust-bitcoin org projects 17:37 < andytoshi> sure, thanks for the find 18:02 < sanket1729> andytoshi: I am also wondering why do we have the DescriptorTrait in the first place? Why not have methods directly on impl Descriptor? 18:07 < sanket1729> Ah, it was for implementing more descriptors in other libs 18:07 < sanket1729> downstream projects --- Log closed Sat Feb 12 00:00:57 2022