--- Log opened Tue Mar 01 00:00:13 2022
00:51 < darosior> miniscript_random improvements look really nice!
01:14 < darosior> Sanket found a bug in the stack size computation, will PR a fix
01:22 < darosior> Here https://github.com/sipa/miniscript/blob/578e1e3f82334f34dc0b3af36492f95ccebe1395/bitcoin/script/miniscript.h#L774 it should be the number of sigs, not the number of keys. I'm surprised this was not caught in any test
01:34 < darosior> sipa: couldn't we merge miniscript_string into decriptor_parse?
01:36 < darosior> Re the finding did you seed it somehow? For descriptor_parse i had interesting strings too but the corpus was initially seeded from the random unit tests. Maybe in the end the string representation is the ultimate encoding for fuzzer efficiency :p
05:22 <@sipa> @darosior sanket: nice catch; I don't understand how this is not being caught
05:23 <@sipa> @darosior No, I didn't seed it with anything.
11:17 <@sipa> darosior: Sure we could merge miniscript_string into descriptor_parse, but I feel that there is sufficient complexity in just the miniscript aspect that it's worth testing on its own (with a fuzzer that isn't distracted by details of e.g. key expressions and the wrappers around it).
11:19 <@sipa> The fuzzer could also invoke TestNode in miniscript_string and/or miniscript_script, but I think that would slow down the fuzzer for no good reason. The miniscript_{stable,smart} fuzzers should already test all relevant properties of valid miniscripts. The only thing _string and _script add is making sure there aren't any invalid things accepted by the relevant parsers, which then get mapped incorrectly to different valid miniscripts.
14:50 -!- warren_ [~warren@fedora/wombat/warren] has joined ##miniscript
14:50 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Ping timeout: 256 seconds]
14:50 -!- kalle [~quassel@user/kallewoof] has quit [Ping timeout: 256 seconds]
14:50 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 256 seconds]
14:51 -!- kalle [~quassel@user/kallewoof] has joined ##miniscript
14:52 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has joined ##miniscript
--- Log closed Wed Mar 02 00:00:14 2022