--- Log opened Tue Apr 19 00:00:59 2022
00:31 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
00:31 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
00:55 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Remote host closed the connection]
00:55 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined ##miniscript
01:33 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
01:33 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
01:57 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
01:57 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
02:19 < darosior> sipa: what do you think of https://github.com/sipa/miniscript/pull/106#discussion_r851200039? It's the approach i've taken for the Bitcoin PRs for output descriptors support and signing support, it seemed a reasonable middle ground to me.
02:23 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
02:23 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
03:18 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
03:18 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
03:39 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
03:39 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
04:06 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
04:06 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
06:28 < darosior> The Rust implem calculation of satisfaction cost in number of stack elements doesn't seem to be tested and seem to be divergent from the C++ one. https://github.com/rust-bitcoin/rust-miniscript/issues/347
06:41 < darosior> On the other hand ms_tests.rs is impressively exhaustive, would be great to have those for the C++ implem i think
07:41 < darosior> Working on fixing those tests for the patch to the type system, interestingly there are a lot of 'after()' but not a single 'older()'.
07:43 <@sipa> darosior: It's not exactly clear to me what you're suggesting, but I'm happy to make a change to only initialize what is needed in each test.
07:44 < darosior> sipa: what i'm suggested, in code rather than words: https://github.com/bitcoin/bitcoin/pull/24860/commits/55de624f33c9467c3f33f3b2f6974df2d7b73a07
07:47 <@sipa> sgtm
08:22 -!- amanr [~sarcastic@218.185.248.66] has joined ##miniscript
08:55 -!- amanr [~sarcastic@218.185.248.66] has quit [Quit: WeeChat 3.5]
09:00 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has joined ##miniscript
09:02 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has quit [Remote host closed the connection]
09:10 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has joined ##miniscript
09:10 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 276 seconds]
09:14 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
09:14 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
09:34 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
09:35 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
10:13 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
10:14 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
10:57 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
10:57 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
11:19 < sanket1729> If I recall correctly, I think I did cross check 20k test vectors from ms_tests.rs with the c++ impl. But it would be great if those can be included in the c++ tests. Those were initially created from Dimitri's alloy spec
11:20 <@sipa> darosior: Do you want me to make changes to #106 ?
11:22 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
11:23 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
11:33 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has quit [Remote host closed the connection]
11:34 < darosior> sipa: yes, as such it cannot be integrated in Bitcoin Core (as the `ECC_Start()` conflicts with other fuzz targets)
11:35 < darosior> Also i think there is an error in the miniscript_string target: https://github.com/sipa/miniscript/pull/106#discussion_r849417429
11:49 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has joined ##miniscript
12:00 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
12:00 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
12:27 < sanket1729> darosior, sipa, andytoshi: Why does `Z` in `or_c` need to be V?
12:27 < andytoshi> sanket1729: without looking, iirc there was a malleability vector
12:27 < sanket1729> or_C = [X] NOTIF [Z] ENDIF
12:27 < andytoshi> thanks
12:27 < andytoshi> hmm
12:28 < andytoshi> oh it's because the output of X gets eaten
12:28 < andytoshi> and Z is only conditionally executed, so it can't have output
12:28 < sanket1729> Ah, right
12:28 < andytoshi> i think if there was a DUPNOTIF we could've used that to avoid this
12:33 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has joined ##miniscript
13:18 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
13:18 -!- shesek_ [~shesek@user/shesek] has joined ##miniscript
13:37 < darosior> That's or_d() :p
13:42 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
13:51 <@sipa> darosior: 55de624f33c9467c3f33f3b2f6974df2d7b73a07 doesn't seem to exist anymore
14:15 < darosior> sipa: https://github.com/bitcoin/bitcoin/pull/24860/commits/7caf83b6b6deaf47db785bfd11ed350142ee59d1 (rebased after the type system fix was merged)
14:22 <@sipa> darosior: Pushed an update to #106
14:25 <@sipa> darosior: What do you think about adding a TestNode() to the miniscript_string test? It'd slow the test down (I haven't benchmarked how much), but it may guide the fuzzer towards more interesting strings.
14:30 -!- salvatoshi [~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr] has quit [Ping timeout: 276 seconds]
14:47 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has quit [Remote host closed the connection]
14:51 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has joined ##miniscript
14:51 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has quit [Remote host closed the connection]
15:11 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has joined ##miniscript
15:14 -!- puefix [~puefix@192-222-138-29.qc.cable.ebox.net] has quit [Remote host closed the connection]
18:42 -!- sanket1729_ [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined ##miniscript
18:42 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Ping timeout: 272 seconds]
18:42 -!- jnewbery [~john@user/jnewbery] has quit [Ping timeout: 272 seconds]
18:44 -!- jnewbery [~john@user/jnewbery] has joined ##miniscript
23:43 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined ##miniscript
--- Log closed Wed Apr 20 00:00:00 2022