--- Log opened Sun May 22 00:00:30 2022 04:12 < kanishk779[m]> Why do we only support very few Descriptor types in rust-miniscript? I am referring to `enum DescriptorType` in src/descriptor folder. 04:12 < kanishk779[m]> For example I was trying to test `"sortedmulti(3,K1,K2,K3)"` and the code says that this descriptor is wrong. 04:37 < kanishk779[m]> Is it okay to commit to a branch and push it to the remote once it has been merged to upstream? Or should I create a new branch, even though the code changes are related to the earlier branch. 04:40 < kanishk779[m]> * trying to run the integration test, * test for `"sortedmulti(3,K1,K2,K3)"` and 04:41 < kanishk779[m]> * Is it okay to commit to a branch and push it to the remote once it has been merged to upstream? Or should I create a new branch, even though the code changes are related to the earlier branch. 04:41 < kanishk779[m]> Here remote --> my fork, upstream --> original rust-miniscript repo and the branch is extreme-tr-tests . 08:13 < sanket1729[m]> kanishk779: in rust-miniscript, those are only supported at nested sh/wsh level. Raw scripts(scripts without sh/wsh) are in general discouraged. 08:13 < sanket1729[m]> You can create a new branch. 11:44 < kanishk779[m]> I have opened a pull request, but I am not sure if the CI tests are running? How long does it take to complete those, Or have they not started because there are some merge conflicts. 11:47 < sanket1729[m]> You would need to rebase your PR on top of latest master to resolve conflicts 11:47 < sanket1729[m]> You can look at online resources for rebasing a branch on top of another branch 11:54 < kanishk779[m]> Will this work :-... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/82a0860c794c92c39cc8e4c78a9be4680cb97ab8) 11:55 < kanishk779[m]> * Will this work :-... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/94d9cd5435183450c53ec39c123401253d806733) 11:57 < sanket1729[m]> after step 1. You can do checkout aman-integration-test and rebase on upstream/master 12:51 < kanishk779[m]> Wow, this is a smart way of doing rebasing. I did not know about this before. I will follow this for future pull requests. 15:12 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Ping timeout: 240 seconds] 15:12 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined ##miniscript 18:17 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has quit [Ping timeout: 250 seconds] 18:23 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has joined ##miniscript 23:07 -!- Netsplit *.net <-> *.split quits: clewe 23:07 -!- Netsplit over, joins: clewe 23:18 -!- Netsplit *.net <-> *.split quits: stevenroose, jeremyrubin, stickies-v 23:18 -!- Netsplit over, joins: stickies-v, stevenroose 23:19 -!- Netsplit over, joins: jeremyrubin --- Log closed Mon May 23 00:00:31 2022