--- Log opened Tue Jun 14 00:00:52 2022 01:21 * darosior is having loads of fun with structs and their friends 01:55 < darosior> What was the rationale for `subs` to be a vector of pointer instead of a vector of Node directly? 02:35 < darosior> Nevermind. 03:40 < darosior> sipa: i've updated https://github.com/darosior/bitcoin/tree/miniscript_parser_static_methods. Unfortunately we can't use `make_shared` with private ctors so i had to fallback to using `shared_ptr<..>(new Node(...))` in `MakeNodeRef`. Do you think your version should be preferred for this reason? See the commit messages for details. 03:42 < darosior> Also it's a large diff but it's just stuff that is moved around in the first two commits. Even if making the parsing functions static sounds "righter", i think i can largely reduce the diff by making them friend (now that i know `make_shared` was the culprit for preventing us to do so it should be easy). 11:17 -!- meshcoll- [meshcollid@meshcollider.jujube.ircnow.org] has joined ##miniscript 11:18 -!- Netsplit *.net <-> *.split quits: meshcollider 12:17 -!- jnewbery_ [~john@user/jnewbery] has joined ##miniscript 12:21 -!- kallewoof [~quassel@user/kallewoof] has joined ##miniscript 12:24 -!- Netsplit *.net <-> *.split quits: jnewbery, kalle 12:40 -!- Guest33 [~Guest33@45.8.223.209] has joined ##miniscript 12:43 -!- Guest33 [~Guest33@45.8.223.209] has quit [Client Quit] 15:37 -!- appservicebot [~afilini-m@2001:bc8:1828:245::2] has quit [Ping timeout: 248 seconds] 15:44 -!- appservicebot [~afilini-m@2001:bc8:1828:245::2] has joined ##miniscript 16:09 -!- appservicebot [~afilini-m@2001:bc8:1828:245::2] has quit [Ping timeout: 258 seconds] 16:19 -!- appservicebot [~afilini-m@2001:bc8:1828:245::2] has joined ##miniscript 17:03 -!- theStack [~theStack@95.179.145.232] has quit [Remote host closed the connection] 17:12 -!- theStack [~theStack@95.179.145.232] has joined ##miniscript --- Log closed Wed Jun 15 00:00:53 2022