--- Log opened Thu Nov 07 00:00:43 2024
05:38 -!- josie_ [~josibake@suhail.uberspace.de] has joined ##miniscript
05:43 -!- josie_ is now known as josie
06:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:a4ad:484a:4330:8e73] has quit [Remote host closed the connection]
08:28 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 276 seconds]
08:28 -!- achow101 [~achow101@user/achow101] has joined ##miniscript
11:23 -!- MichaelTidwell [~MichaelTi@2600:1700:fc5:38b0:5c99:dd42:16bc:3052] has joined ##miniscript
11:35 < MichaelTidwell> Look for guidance, I have a PR open and I'm failing some tests.
11:35 < MichaelTidwell> https://github.com/rust-bitcoin/rust-miniscript/actions/runs/11670731947/job/32496857388?pr=766#step:6:1313
11:35 < MichaelTidwell> I'm interested in fixing these errors locally before pushing another change, but I'm struggling to reproduce the same issues on my local fork of the code base. I've tried using the same version in rust-bitcoin: nightly-2024-11-03, and the recommended: "just lint".
11:48 <@andytoshi> hiya
11:48 -!- MichaelTidwell [~MichaelTi@2600:1700:fc5:38b0:5c99:dd42:16bc:3052] has quit [Quit: Client closed]
11:48 <@andytoshi> ah just missed you
11:50 -!- MichaelTidwell [~MichaelTi@2600:1700:fc5:38b0:5c99:dd42:16bc:3052] has joined ##miniscript
11:53 <@andytoshi> MichaelTidwell: welcome back
11:53 <@andytoshi> so, it looks like you arehaving issues with rust 1.63 which is our MSRV
11:53 <@andytoshi> (minimum supported rust version)
11:54 <@andytoshi> i think yo can reproduce this locally with
11:54 <@andytoshi> cargo +1.63.0 run --example taptree_of_horror --features compiler
11:54 <@andytoshi> ...yep, that works. you might need to install 1.63, with `rustup install 1.63.0`
11:55 <@andytoshi> MichaelTidwell: in this case you're using `let else` to destructure a slice into 8 separate variables. i think you can convert the slice to an array, unwrap that, then destructure the array
11:58 < MichaelTidwell> im going to try using the syntax like:
11:58 < MichaelTidwell> let (a0, a1, a2, a3, a4, a5, a6, a7, a8) = match &a_pks[..] {
11:58 < MichaelTidwell>         &[a0, a1, a2, a3, a4, a5, a6, a7, a8] => (a0, a1, a2, a3, a4, a5, a6, a7, a8),
11:58 < MichaelTidwell>         _ => panic!("Expected exactly 8 elements in alice_pk_keys"),
11:58 < MichaelTidwell>     };
11:58 < MichaelTidwell> Which keeps the simple ideas of having a bunch of keys to use willynilly that are explicit, but now uses a match.. using your suggested commands I'm able to reproduce the errors and I see the new match syntax is acceptable
12:00 < MichaelTidwell> ok, just push -f a new commit, feeling good about this one, will wait for the tests to see.
12:06 <@andytoshi> yep that'd work
12:06 <@andytoshi> just started tests (for some reason github wants me to click "approve" because you're new to the repo)
12:22 < MichaelTidwell> mini-carbon footprint for mini-script ci
12:23 <@andytoshi> hehe
13:09 < MichaelTidwell> andytoshi nice, tests passed. thanks for the help. I think for next steps for the PR i'll just wait for someone to review?
13:10 <@andytoshi> MichaelTidwell: yep. i think i can do it this evening or tomorrow
13:10 <@andytoshi> i have a blog post i've gotta write first
14:10 -!- MichaelTidwell [~MichaelTi@2600:1700:fc5:38b0:5c99:dd42:16bc:3052] has quit [Quit: Client closed]
14:19 -!- MichaelTidwell [~MichaelTi@2600:1700:fc5:38b0:5c99:dd42:16bc:3052] has joined ##miniscript
14:19 -!- MichaelTidwell [~MichaelTi@2600:1700:fc5:38b0:5c99:dd42:16bc:3052] has quit [Client Quit]
--- Log closed Fri Nov 08 00:00:44 2024