public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: "Michael Offel" <michael.offel@web•de>
To: "'Bitcoin Dev'" <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] There will be a release candidate 6...
Date: Thu, 17 Nov 2011 15:35:36 -0000	[thread overview]
Message-ID: <002d01cca53e$9552d1d0$bff87570$@offel@web.de> (raw)
In-Reply-To: <CABsx9T2vRq++uqu=23YG86uQ=9ZpwjYv_8hOinWRyrd9YLv_PQ@mail.gmail.com>

If you are going to support this use case, you should also notify the user
on wallet changes that results in invalidated backup. For example whenever
the key pool gets extended.

-----Original Message-----
From: Gavin Andresen [mailto:gavinandresen@gmail•com] 
Sent: 17 November 2011 14:28
To: Bitcoin Dev
Subject: [Bitcoin-development] There will be a release candidate 6...

I got email from a tester who gave this feedback:

> I think that user behaviour: encrypt wallet -> backup -> do some 
> activity -> restore backup -> BOOM. Is perfectly natural user 
> behaviour and it will happen. For example when generating a wallet on 
> a secure computer and then moving it to an insecure one.

I agree that is likely to happen and, when it does, will be disastrous.
So I'll be reworking the wallet encrypt/rewrite code today and creating a
release candidate 6.

My previous attempt (encrypt, invalidating keypool, then unlock and write a
new keypool) resulted in unencrypted private keys in the new wallet.

I think this will work, I'll implement and test today.

Invalidate all the old keypool keys in the old wallet.Write new keypool keys
to the old wallet.Encrypt all the keys in the old wallet.Rewrite the old
wallet to create a new wallet.Shutdown/restart.
IF ANYBODY IS WILLING TO HELP:

There is still a mysterious problem with bdb throwing an exception when
dbenv.close(0) is called during shutdown. If you can compile a -g version of
bdb and then step through DbEnv::close in a debugger and tell me why it is
throwing an exception that would be extremely helpful.
--
--
Gavin Andresen

----------------------------------------------------------------------------
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security threats,
fraudulent activity, and more. Splunk takes this data and makes sense of it.
IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Bitcoin-development mailing list
Bitcoin-development@lists•sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitcoin-development




      reply	other threads:[~2011-11-17 15:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 14:28 Gavin Andresen
2011-11-17 15:35 ` Michael Offel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002d01cca53e$9552d1d0$bff87570$@offel@web.de' \
    --to=michael.offel@web$(echo .)de \
    --cc=bitcoin-development@lists$(echo .)sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox