From: Matt Corallo <bitcoin-list@bluematt•me>
To: bitcoin-development <bitcoin-development@lists•sourceforge.net>
Subject: [Bitcoin-development] Warning to rawtx creators: bug in SIGHASH_SINGLE
Date: Mon, 20 Aug 2012 12:06:14 -0400 [thread overview]
Message-ID: <1345478774.3471.4.camel@bmthinkpad.lan.bluematt.me> (raw)
If you are playing around with the current rawtx API, be careful using
SIGHASH_SINGLE:
When parsing a transaction input, which uses a SIGHASH_SINGLE signature,
and the given input's index is >= the total number of outputs in the
current transaction, bitcoind doesn't sign anything useful, it signs the
constant 1.
Thus, if anyone were to create such an invalid transaction, any future
outputs to the public key which created the signature would be
immediately steal-able by anyone.
The conclusion on how to fix the issue was to fix the rawtx API to block
such transactions instead of creating a hardfork-risk or further
complicating transaction verification.
Code (in script.cpp:SignatureHash, under SIGHASH_SINGLE):
if (nOut >= txTmp.vout.size())
{
printf("ERROR: SignatureHash() : nOut=%d out of range\n", nOut);
return 1;
}
Matt
reply other threads:[~2012-08-20 16:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345478774.3471.4.camel@bmthinkpad.lan.bluematt.me \
--to=bitcoin-list@bluematt$(echo .)me \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox