public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Turkey Breast <turkeybreast@yahoo•com>
To: "bitcoin-development@lists•sourceforge.net"
	<bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message
Date: Tue, 18 Jun 2013 15:30:30 -0700 (PDT)	[thread overview]
Message-ID: <1371594630.18036.YahooMailNeo@web162703.mail.bf1.yahoo.com> (raw)
In-Reply-To: <CANEZrP0ViJSQr_UUxLqM-eFTir=-FGwZ2cSxuPgaVi=KiM8gsA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]

That's me. I never said to make all messages fixed length. I said to make a fixed number of fields per protocol. So given a protocol version number, you know the number of fields in a message. This is not only easier for parsing messages, but just good practice. I don't see why a 1 byte flag needs to be optional anyway.



________________________________
 From: Mike Hearn <mike@plan99•net>
To: Turkey Breast <turkeybreast@yahoo•com> 
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net> 
Sent: Tuesday, June 18, 2013 9:48 PM
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version message
 


It's not a bug (although there was recently a change to make bitcoind/qt always send this field anyway). 

I don't know where Amir is going with BIP 60. Version messages have always been variable length. There's nothing inherent in the Bitcoin protocol that says all messages are fixed length, indeed, tx messages are allowed to have arbitrary data appended after them that gets relayed.



On Tue, Jun 18, 2013 at 7:45 PM, Turkey Breast <turkeybreast@yahoo•com> wrote:

See this BIP. I'm not sure if this is a bug or what, but it would be good if messages always had a fixed number of fields per protocol version.
>
>
>https://en.bitcoin.it/wiki/BIP_0060#Code_Updates
>
>
>This BIP details everything that needs to be done and proposes a protocol upgrade.
>
>------------------------------------------------------------------------------
>This SF.net email is sponsored by Windows:
>
>Build for Windows Store.
>
>http://p.sf.net/sfu/windows-dev2dev
>_______________________________________________
>Bitcoin-development mailing list
>Bitcoin-development@lists•sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>

[-- Attachment #2: Type: text/html, Size: 4038 bytes --]

  reply	other threads:[~2013-06-18 22:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 17:45 Turkey Breast
2013-06-18 19:48 ` Mike Hearn
2013-06-18 22:30   ` Turkey Breast [this message]
2013-06-19  9:39     ` Mike Hearn
2013-06-19 10:33       ` Turkey Breast
2013-06-19 10:43         ` Mike Hearn
2013-06-19 13:03 Paul Lyon
2013-06-19 13:20 ` Mike Hearn
2013-06-20  6:20   ` Turkey Breast
2013-06-20  7:10     ` Mike Hearn
2013-06-20  7:13     ` Addy Yeow
2013-06-20 13:35       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371594630.18036.YahooMailNeo@web162703.mail.bf1.yahoo.com \
    --to=turkeybreast@yahoo$(echo .)com \
    --cc=bitcoin-development@lists$(echo .)sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox