From: Olivier Langlois <olivier@trillion01•com>
To: Ron <rdwnj@yahoo•com>
Cc: "bitcoin-development@lists•sourceforge.net"
<bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] on CDB::Rewrite()
Date: Thu, 03 Oct 2013 23:23:49 -0400 [thread overview]
Message-ID: <1380857029.932.49.camel@Wailaba2> (raw)
In-Reply-To: <1380770163.7534.YahooMailNeo@web124502.mail.ne1.yahoo.com>
> Upon looking at the 0.8.5 & earlier code for CDB:Rewrite(), in the
> files db.h and db.cpp, you will notice that in db.h it is declared
> bool static, but in db.cpp it isn't. Is this a problem? Or a feature?
> Or nothing at all?
It is perfect C++ code.
> Furthermore, it is called only in wallet.cpp
> -->CWallet::EncryptWallet() but its return value is ignored? Again,
> intentional or a bug or a feature or a ...?
possibly a minor bug. Minor because over 99% of the time it is called, the Rewrite() function will succeed.
Maybe CWallet::EncryptWallet() should return false to its callers when
CDB::Rewrite fails.
prev parent reply other threads:[~2013-10-04 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 3:16 Ron
2013-10-04 3:23 ` Olivier Langlois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380857029.932.49.camel@Wailaba2 \
--to=olivier@trillion01$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=rdwnj@yahoo$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox