From: "Luke-Jr" <luke@dashjr•org>
To: bitcoin-development@lists•sourceforge.net
Cc: Michael Offel <Michael.Offel@web•de>
Subject: Re: [Bitcoin-development] overall bitcoin client code quality
Date: Sun, 10 Jul 2011 22:01:51 -0400 [thread overview]
Message-ID: <201107102201.53937.luke@dashjr.org> (raw)
In-Reply-To: <97305540.4426247.1310337435268.JavaMail.fmail@mwmweb052>
On Sunday, July 10, 2011 6:37:15 PM Michael Offel wrote:
> why Berkeley db 4 is used at all.
Because it's a good tool for the job? Or you mean the version?
Debian stable: 4.8
Gentoo stable: 4.8
Ubuntu LTS : 4.8
> Boost is also an heavy non standard dependency that is an unnecessary
> barrier for new developers.
Boost is pretty much standard C++ nowadays.
> I'm talking about one file per class, no methods and single code line
> longer than a screen page. It should be natural to write code like this
> and I dislike having a lot of rules but the code shows that there is a
> need for such thing.
Blame your text editor if it can't show long lines sanely. The only problem I
see with the style itself is the use of spaces instead of tabs.
> My overall suggestion is to begin a complete rewrite, inspired by the old
> code rather than moving a lot of "known to be somehow functional" around.
There are many rewrites in progress, often with much better designs.
> The official Bitcoin client should be some kind of an reference project
> for other clients and must therefore be extra clean and well documented.
Bitcoin is supposed to be an authorityless project. There is no official.
> *everything else*
Fix it yourself and submit the changes. If they don't get merged, fork.
next prev parent reply other threads:[~2011-07-11 2:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 22:37 Michael Offel
2011-07-10 23:07 ` Douglas Huff
2011-07-10 23:31 ` Jeff Garzik
2011-07-10 23:36 ` Matt Corallo
2011-07-11 2:01 ` Luke-Jr [this message]
2011-07-12 4:13 ` Alan Grimes
2011-07-12 5:19 ` Jeff Garzik
2011-07-11 9:33 ` Mike Hearn
2011-07-12 3:31 ` Gavin Andresen
2011-07-12 7:21 ` John Smith
2011-07-12 22:50 ` Michael Offel
2011-07-12 21:47 Michael Offel
2011-07-12 23:40 ` Gregory Maxwell
2011-07-13 0:17 ` Matt Corallo
2011-07-13 11:50 ` Mike Hearn
2011-07-13 13:04 ` Andy Parkins
2011-07-13 18:37 ` Luke-Jr
2011-07-13 21:41 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107102201.53937.luke@dashjr.org \
--to=luke@dashjr$(echo .)org \
--cc=Michael.Offel@web$(echo .)de \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox