From: "Luke-Jr" <luke@dashjr•org>
To: Gavin Andresen <gavinandresen@gmail•com>
Cc: bitcoin-development@lists•sourceforge.net
Subject: Re: [Bitcoin-development] [PULL] When parsing base58 data, accept [0O] as o, and [l|!] as 1
Date: Fri, 12 Aug 2011 12:43:22 -0400 [thread overview]
Message-ID: <201108121243.24207.luke@dashjr.org> (raw)
In-Reply-To: <CABsx9T0iCYr591RVXA40mHMU75sEL0AfbbBHXFaz0XLFp6_kFQ@mail.gmail.com>
On Friday, August 12, 2011 12:35:27 PM Gavin Andresen wrote:
> pszDecode58 is not a pointer to a zero-terminated string; it should be
> pnDecode58.
Updated variable name in branch...
> I'm torn between "meh, whatever" and "this will just cause people
> headaches when they wonder why vanity addresses don't work in
> blockexplorer because theymos decides not to bother changing his
> code..."
Perhaps the vanity use would need to be introduced only after the community
has accepted these as alternative legitimate representations. Even without
that, I think gracefully handling the typos would be sensible.
prev parent reply other threads:[~2011-08-12 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 16:19 Luke-Jr
[not found] ` <CABsx9T0iCYr591RVXA40mHMU75sEL0AfbbBHXFaz0XLFp6_kFQ@mail.gmail.com>
2011-08-12 16:43 ` Luke-Jr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108121243.24207.luke@dashjr.org \
--to=luke@dashjr$(echo .)org \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=gavinandresen@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox