public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed

* [Bitcoin-development] [PULL] When parsing base58 data, accept [0O] as o, and [l|!] as 1
@ 2011-08-12 16:19 Luke-Jr
       [not found] ` <CABsx9T0iCYr591RVXA40mHMU75sEL0AfbbBHXFaz0XLFp6_kFQ@mail.gmail.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Luke-Jr @ 2011-08-12 16:19 UTC (permalink / raw)
  To: bitcoin-development

http://tinyurl.com/3gpvrhm

git fetch git://gitorious.org/~Luke-Jr/bitcoin/luke-jr-bitcoin.git \
 base58_liberal_parsing && git merge FETCH_HEAD

This simple modification allows base58 inputs to use zero and uppercase 'O' in 
place of lowercase 'O', as well as lowercase 'L', bar/pipe, and exclamation 
point in place of one. This allows more tolerance when inputting addresses or 
other data by manual typing, and gives a bit more variety to vanity addresses.



^ permalink raw reply	[flat|nested] 2+ messages in thread

• [parent not found: <CABsx9T0iCYr591RVXA40mHMU75sEL0AfbbBHXFaz0XLFp6_kFQ@mail.gmail.com>]

• • * Re: [Bitcoin-development] [PULL] When parsing base58 data, accept [0O] as o, and [l|!] as 1
           [not found] ` <CABsx9T0iCYr591RVXA40mHMU75sEL0AfbbBHXFaz0XLFp6_kFQ@mail.gmail.com>
    @ 2011-08-12 16:43   ` Luke-Jr
      0 siblings, 0 replies; 2+ messages in thread
    From: Luke-Jr @ 2011-08-12 16:43 UTC (permalink / raw)
      To: Gavin Andresen; +Cc: bitcoin-development
    
    On Friday, August 12, 2011 12:35:27 PM Gavin Andresen wrote:
    > pszDecode58 is not a pointer to a zero-terminated string; it should be
    > pnDecode58.
    
    Updated variable name in branch...
    
    > I'm torn between "meh, whatever" and "this will just cause people
    > headaches when they wonder why vanity addresses don't work in
    > blockexplorer because theymos decides not to bother changing his
    > code..."
    
    Perhaps the vanity use would need to be introduced only after the community 
    has accepted these as alternative legitimate representations. Even without 
    that, I think gracefully handling the typos would be sensible.
    
    
    
    ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-12 16:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-12 16:19 [Bitcoin-development] [PULL] When parsing base58 data, accept [0O] as o, and [l|!] as 1 Luke-Jr
     [not found] ` <CABsx9T0iCYr591RVXA40mHMU75sEL0AfbbBHXFaz0XLFp6_kFQ@mail.gmail.com>
2011-08-12 16:43   ` Luke-Jr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox