From: Anthony Towns <aj@erisian•com.au>
To: Matt Corallo <lf-lists@mattcorallo•com>,
Bitcoin Protocol Discussion
<bitcoin-dev@lists•linuxfoundation.org>
Subject: Re: [bitcoin-dev] Proposal for new "disabletx" p2p message
Date: Thu, 14 Jan 2021 15:32:57 +1000 [thread overview]
Message-ID: <20210114053257.4ctg3qdvo7s44s72@erisian.com.au> (raw)
In-Reply-To: <10E92E80-75A3-4C45-8CEA-F1EAA2149761@mattcorallo.com>
On Wed, Jan 13, 2021 at 01:40:03AM -0500, Matt Corallo via bitcoin-dev wrote:
> Out of curiosity, was the interaction between fRelay and bloom disabling ever
> specified? ie if you aren’t allowed to enable bloom filters on a connection due
> to resource constraints/new limits, is it ever possible to “set” fRelay later?
(Maybe I'm missing something, but...)
In the current bitcoin implementation, no -- you either set
m_tx_relay->fRelayTxes to true via the VERSION message (either explicitly
or by not setting fRelay), or you enable it later with FILTERLOAD or
FILTERCLEAR, both of which will cause a disconnect if bloom filters
aren't supported. Bloom filter support is (optionally?) indicated via
a service bit (BIP 111), so you could assume you know whether they're
supported as soon as you receive the VERSION line.
fRelay is specified in BIP 37 as:
| 1 byte || fRelay || bool || If false then broadcast transactions will
not be announced until a filter{load,add,clear} command is received. If
missing or true, no change in protocol behaviour occurs.
BIP 60 defines the field as "relay" and references BIP 37. Don't think
it's referenced in any other bips.
Cheers,
aj
next prev parent reply other threads:[~2021-01-14 5:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 16:35 Suhas Daftuar
2021-01-13 6:40 ` Matt Corallo
2021-01-14 5:32 ` Anthony Towns [this message]
2021-01-14 5:39 ` Matt Corallo
2021-01-14 6:46 ` Anthony Towns
2021-01-19 19:19 ` Suhas Daftuar
2021-03-01 20:58 ` John Newbery
2021-03-01 23:11 ` Antoine Riard
2021-03-02 12:11 ` John Newbery
2021-03-02 22:42 ` Antoine Riard
2021-03-02 16:31 ` Anthony Towns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114053257.4ctg3qdvo7s44s72@erisian.com.au \
--to=aj@erisian$(echo .)com.au \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
--cc=lf-lists@mattcorallo$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox