From: Anthony Towns <aj@erisian•com.au>
To: Matt Corallo <lf-lists@mattcorallo•com>,
Bitcoin Protocol Discussion
<bitcoin-dev@lists•linuxfoundation.org>
Cc: Michael Folkson <michaelfolkson@gmail•com>
Subject: Re: [bitcoin-dev] Yesterday's Taproot activation meeting on lockinontimeout (LOT)
Date: Mon, 22 Feb 2021 15:16:24 +1000 [thread overview]
Message-ID: <20210222051624.6eklzfec2bf4lqdk@erisian.com.au> (raw)
In-Reply-To: <ce8925d5-d2f1-1adb-530d-36f89f5b6352@bluematt.me>
On Fri, Feb 19, 2021 at 12:48:00PM -0500, Matt Corallo via bitcoin-dev wrote:
> It was pointed out to me that this discussion is largely moot as the
> software complexity for Bitcoin Core to ship an option like this is likely
> not practical/what people would wish to see.
> Bitcoin Core does not have infrastructure to handle switching consensus
> rules with the same datadir - after running with uasf=true for some time,
> valid blocks will be marked as invalid,
I don't think this is true? With the current proposed bip8 code,
lockinontimeout=true will cause headers to be marked as invalid, and
won't process the block further. If a node running lockinontimeout=true
accepts the header, then it will apply the same consensus rules as a
lockinontimeout=false node.
I don't think an invalid header will be added to the block index at all,
so a node restart should always cleanly allow it to be reconsidered.
The test case in
https://github.com/bitcoin/bitcoin/pull/19573/commits/bd8517135fc839c3332fea4d9c8373b94c8c9de8
tests that a node that had rejected a chain due to lockinontimeout=true
will reorg to that chain after being restarted as a byproduct of the way
it tests different cases (the nodes set a new startheight, but retain
their lockinontimeout settings).
(I think with the current bip8 code, if you switch from
lockinontimeout=false to lockinontimeout=true and the tip of the current
most work chain is after the timeoutheight and did not lockin, then you
will continue following that chain until a taproot-invalid transaction
is inclued, rather than immediately reorging to a shorter chain that
complies with the lockinontimeout=true rules)
Cheers,
aj
next prev parent reply other threads:[~2021-02-22 5:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 12:51 Michael Folkson
2021-02-18 5:43 ` Ariel Lorenzo-Luaces
2021-02-18 11:01 ` Michael Folkson
2021-02-18 11:11 ` Samson Mow
2021-02-18 11:52 ` ZmnSCPxj
2021-02-18 12:20 ` Michael Folkson
2021-02-18 14:01 ` Matt Corallo
2021-02-18 14:26 ` Michael Folkson
2021-02-18 14:42 ` Matt Corallo
2021-02-18 14:51 ` Michael Folkson
2021-02-18 14:53 ` Matt Corallo
2021-02-18 15:01 ` Matt Corallo
2021-02-18 15:04 ` Keagan McClelland
2021-02-18 15:18 ` Matt Corallo
2021-02-19 2:20 ` Ariel Luaces
2021-02-19 11:30 ` ZmnSCPxj
2021-02-19 12:05 ` Adam Back
2021-02-19 14:13 ` Matt Corallo
2021-02-19 17:48 ` Matt Corallo
2021-02-20 2:55 ` ZmnSCPxj
2021-02-20 17:20 ` Ariel Lorenzo-Luaces
2021-02-21 14:30 ` Matt Corallo
2021-02-22 5:16 ` Anthony Towns [this message]
2021-02-22 6:44 ` Matt Corallo
2021-02-22 10:16 ` Anthony Towns
2021-02-22 14:00 ` Matt Corallo
2021-02-22 16:27 ` Anthony Towns
2021-02-22 16:31 ` Jorge Timón
2021-02-22 16:48 ` Jorge Timón
2021-02-23 2:10 ` Jeremy
2021-02-23 19:33 ` Keagan McClelland
2021-02-23 23:14 ` Ben Woosley
2021-02-24 22:37 ` Ariel Luaces
2021-03-01 13:54 ` Erik Aronesty
2021-03-02 18:32 ` Ariel Lorenzo-Luaces
2021-02-24 7:18 ` Anthony Towns
2021-02-18 13:59 ` Matt Corallo
2021-02-21 16:21 ` Erik Aronesty
2021-02-19 22:12 Matt Hill
2021-02-19 23:30 ` Matt Corallo
2021-02-19 23:42 ` Bryan Bishop
2021-02-21 10:10 Prayank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222051624.6eklzfec2bf4lqdk@erisian.com.au \
--to=aj@erisian$(echo .)com.au \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
--cc=lf-lists@mattcorallo$(echo .)com \
--cc=michaelfolkson@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox