From: Anthony Towns <aj@erisian•com.au>
To: Gloria Zhao <gloriajzhao@gmail•com>,
Bitcoin Protocol Discussion
<bitcoin-dev@lists•linuxfoundation.org>
Subject: Re: [bitcoin-dev] Package Relay Proposal
Date: Wed, 18 May 2022 10:35:31 +1000 [thread overview]
Message-ID: <20220518003531.GA4402@erisian.com.au> (raw)
In-Reply-To: <CAFXO6=JROe_9ih2h+_CCH-UbxehsM5RQ6YyNnPesEpveBEtdow@mail.gmail.com>
On Tue, May 17, 2022 at 12:01:04PM -0400, Gloria Zhao via bitcoin-dev wrote:
> ====New Messages====
> Three new protocol messages are added for use in any version of
> package relay. Additionally, each version of package relay must define
> its own inv type and "pckginfo" message version, referred to in this
> document as "MSG_PCKG" and "pckginfo" respectively. See
> BIP-v1-packages for a concrete example.
The "PCKG" abbreviation threw me for a loop; isn't the usual
abbreviation "PKG" ?
> =====sendpackages=====
> |version || uint32_t || 4 || Denotes a package version supported by the
> node.
> |max_count || uint32_t || 4 ||Specifies the maximum number of transactions
> per package this node is
> willing to accept.
> |max_weight || uint32_t || 4 ||Specifies the maximum total weight per
> package this node is willing
> to accept.
Does it make sense for these to be configurable, rather than implied
by the version?
I presume the idea is to cope with people specifying different values for
-limitancestorcount or -limitancestorsize, but if people are regularly
relaying packages around, it seems like it becomes hard to have those
values really be configurable while being compatible with that?
I guess I'm asking: would it be better to either just not do sendpackages
at all if you're limiting ancestors in the mempool incompatibly; or
alternatively, would it be better to do the package relay, then reject
the particular package if it turns out too big, and log that you've
dropped it so that the node operator has some way of realising "whoops,
I'm not relaying packages properly because of how I configured my node"?
> 5. If 'fRelay==false' in a peer's version message, the node must not
> send "sendpackages" to them. If a "sendpackages" message is
> received by a peer after sending `fRelay==false` in their version
> message, the sender should be disconnected.
Seems better to just say "if you set fRelay=false in your version
message, you must not send sendpackages"? You already won't do packages
with the peer if they don't also announce sendpackages.
> 7. If both peers send "wtxidrelay" and "sendpackages" with the same
> version, the peers should announce, request, and send package
> information to each other.
Maybe: "You must not send sendpackages unless you also send wtxidrelay" ?
As I understand it, the two cases for the protocol flow are "I received
an orphan, and I'd like its ancestors please" which seems simple enough,
and "here's a child you may be interested in, even though you possibly
weren't interested in the parents of that child". I think the logic for
the latter is:
* if tx C's fee rate is less than the peer's feefilter, skip it
(will maybe treat it as a parent in some package later though)
* if tx C's ancestor fee rate is less than the peer's feefilter, skip
it?
* look at the lowest ancestor fee rate for any of C's in-mempool
parents
* if that is higher than the peer's fee filter, send a normal INV
* if it's lower than the peer's fee filter, send a PCKG INV
Are "getpckgtxns" / "pcktxns" really limited to packages, or are they
just a general way to request a batch of transactions? Particularly in
the case of requesting the parents of an orphan tx you already have,
it seems hard for the node receiving getpckgtxns to validate that the
txs are related in some way; but also it doesn't seem very necessary?
Maybe call those messages "getbatchtxns" and "batchtxns" and allow them to
be used more generally, potentially in ways unrelated to packages/cpfp?
The "only be sent if both peers agreed to do package relay" rule could
simply be dropped, I think.
> 4. The reciever uses the package information to decide how to request
> the transactions. For example, if the receiver already has some of
> the transactions in their mempool, they only request the missing ones.
> They could also decide not to request the package at all based on the
> fee information provided.
Shouldn't the sender only be sending package announcements when they know
the recipient will be interested in the package, based on their feefilter?
> =====pckginfo1=====
> {|
> | Field Name || Type || Size || Purpose
> |-
> |blockhash || uint256 || 32 || The chain tip at which this package is
> defined.
> |-
> |pckg_fee||CAmount||4|| The sum total fees paid by all transactions in the
> package.
CAmount in consensus/amount.h is a int64_t so shouldn't this be 8
bytes? If you limit a package to 101kvB, an int32_t is enough to cover
any package with a fee rate of about 212 BTC/block or lower, though.
> |pckg_weight||int64_t||8|| The sum total weight of all transactions in the
> package.
The maximum block weight is 4M, and the default -limitancestorsize
presumably implies a max package weight of 404k; seems odd to provide
a uint64_t rather than an int32_t here, which easily allows either of
those values?
> 2. ''Only 1 child with unconfirmed parents.'' The package must consist
> of one transaction and its unconfirmed parents. There must not be
> any other transactions in the package. Other dependency relationships
> may exist within the package (e.g. one parent may spend the output of
> another parent) provided that topological order is respected.
I think this means that some of the parents could also have unconfirmed
parents, but they won't be included in the package, and must be requested
via the recipient-initiated approach?
> 5. ''Total fees and weight.'' The 'total_fee' and 'total_weight'
> fields must accurately represent the sum total of all transactions'
> fees and weights as defined in BIP141, respectively.
Presumably this excludes any unconfirmed grandparents and earlier
ancestors since they aren't part of the package, in this approach? Doesn't
that make this both harder to calculate (assuming we already have
ancestor summaries) and less useful, in the case where those ancestors
have a lower fee rate?
> ''Q: Can "getpckgtxns" and "pckgtxns" messages contain only one
> transaction?''
> Yes.
This would be normal if you're requesting a single missing parent for
an orphan you've received, I think?
I'm slightly surprised the process is:
-> INV PCKG1 C
<- GETDATA PCKG1 C
-> PCKGINFO1 blockhash A B C fee weight
rather than announcing the package fee info in the first message.
But if the sender is already applying the feefilter to the package before
announcing it, it probably doesn't matter, and means you're only getting
a 32B INV from every peer, rather than a 32*(n+2) PCKGINFO1 message from
every peer.
I guess tx relay is low priority enough that it wouldn't be worth tagging
some peers as "high bandwidth" and having them immediately announce the
PCKGINFO1 message, and skip the INV/GETDATA step?
Cheers,
aj
next prev parent reply other threads:[~2022-05-18 0:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 16:01 Gloria Zhao
2022-05-17 17:56 ` Greg Sanders
2022-05-17 20:45 ` Gloria Zhao
2022-05-18 0:35 ` Anthony Towns [this message]
2022-05-18 18:40 ` Gloria Zhao
2022-05-23 21:34 ` Anthony Towns
2022-05-24 1:13 ` Gloria Zhao
2022-05-24 19:48 ` Anthony Towns
2022-05-24 21:05 ` Gloria Zhao
2022-05-24 23:43 ` Eric Voskuil
2022-05-25 18:55 ` Anthony Towns
2022-05-25 20:52 ` eric
2022-05-26 2:59 ` eric
2022-06-07 17:44 ` Gloria Zhao
2022-06-08 15:59 ` Suhas Daftuar
2022-06-14 9:59 ` Gloria Zhao
2022-05-28 1:54 ` Gloria Zhao
2022-06-17 20:08 ` Antoine Riard
2022-11-01 18:03 ` Gloria Zhao
2023-05-10 15:12 Tom Trevethan
2023-05-10 15:42 ` Greg Sanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518003531.GA4402@erisian.com.au \
--to=aj@erisian$(echo .)com.au \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
--cc=gloriajzhao@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox