public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: kjj <bitcoin-devel@jerviss•org>
To: Gavin Andresen <gavinandresen@gmail•com>
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Feedback requested: "reject" p2p message
Date: Sun, 27 Oct 2013 21:52:58 -0500	[thread overview]
Message-ID: <526DD18A.7060201@jerviss.org> (raw)
In-Reply-To: <CABsx9T2OMA_u=S9yUh2j78QDuCDUorYctktuixjwAjqc6neW=Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

Any reason not to use actual HTTP codes?  I'm not aware of any major 
deficiency in them.  Most of them won't apply to us, which is fine, they 
don't seem to apply to HTTP either.  We can extend the scheme on our own 
if we find a good reason to.

That implies 16 bits, or a varint.  I would avoid a string or varstring 
here; we already have a text field.  Varint vs. 16 bits is a minor 
issue, and arguments can be made in both directions.  I flipped a coin 
and got heads, so I'll say varint.

Gavin Andresen wrote:
> RE: use HTTP-like status codes:
>
> Okey dokey, I'll add a one-byte machine-readable HTTP-like status 
> code. Unless y'all want a 32-bit status code.  Or maybe a varint. Or a 
> three-character numeric string. I really and truly don't care, but I 
> am writing this code right now so whatever you want, decide quickly.
>
> If anybody has strong feelings about what the reject categories should 
> be, then please take the time to write a specific list, I can't read 
> your mind....
>
>
> -- 
> --
> Gavin Andresen
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
>
>
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists•sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development


[-- Attachment #2: Type: text/html, Size: 2928 bytes --]

  reply	other threads:[~2013-10-28  2:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-26  0:34 Gavin Andresen
2013-10-26  1:01 ` Jean-Paul Kogelman
2013-10-26  2:00   ` Gavin
2013-10-26  4:32     ` kjj
2013-10-27 14:32       ` Mike Hearn
2013-10-27 14:39         ` Luke-Jr
2013-10-27 14:50           ` Mike Hearn
2013-10-30 17:13         ` Gregory Maxwell
2013-10-31 12:01           ` Mike Hearn
2013-10-27 22:52       ` Gavin Andresen
2013-10-28  2:52         ` kjj [this message]
2013-10-28  9:26           ` Andreas Schildbach
2013-10-28  9:32             ` Gregory Maxwell
2013-10-29  5:37               ` Gavin Andresen
2013-10-29  8:55                 ` Warren Togami Jr.
2013-10-29  9:12                   ` Peter Todd
2013-10-29  9:52                 ` Mike Hearn
2013-10-29 10:14                   ` Peter Todd
2013-10-29 11:38                     ` Peter Todd
2013-10-29 12:32                       ` Mike Hearn
2013-10-29 16:35                         ` [Bitcoin-development] On soft-forks and hard-forks Peter Todd
2013-10-30  2:01                         ` [Bitcoin-development] Feedback requested: "reject" p2p message Gavin Andresen
2013-10-30  8:24                           ` Mike Hearn
2013-10-30  9:05                             ` Mark Friedenbach
2013-10-30 10:26                               ` Mike Hearn
2013-10-28  2:59         ` Luke-Jr
2013-10-28  3:02         ` Pieter Wuille

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526DD18A.7060201@jerviss.org \
    --to=bitcoin-devel@jerviss$(echo .)org \
    --cc=bitcoin-development@lists$(echo .)sourceforge.net \
    --cc=gavinandresen@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox