From: Jouke Hofman <jouke@bitonic•nl>
To: bitcoin-development@lists•sourceforge.net
Subject: Re: [Bitcoin-development] Proposal to change payment protocol signing
Date: Tue, 29 Apr 2014 18:44:12 +0200 [thread overview]
Message-ID: <535FD6DC.8000002@bitonic.nl> (raw)
In-Reply-To: <CABsx9T2v=oX5eR9yoBULPVceZFD2_d+xMF7jQJACHYP=FgWK-A@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
We have BIP70 already in use (over a hundred paid requests).
Could you elaborate on why this needs changing?
On 28-04-14 14:39, Gavin Andresen wrote:
> There is a discussion about clarifying how BIP70 signs payment
> requests here: https://github.com/bitcoin/bips/pull/41
>
> The issue is what to do with the signature field before signing.
> The code Mike and I initially wrote does this:
>
> request.set_signature(string(""));
>
> (sets signature to the empty string)
>
> I think that is a mistake; it should be:
>
> request.clear_signature();
>
> (clears signature field, so it is not serialized at all).
>
> So: if you are implementing, or have implemented, the payment
> protocol, please chime in. I'd like to change the spec and the
> reference implementation NOW, while BIP70 is still a 'Draft'.
>
> Because this type of "hey, I'm implementing your standard and it
> doesn't work the way I think it should" mistake is exactly why BIPs
> take a while before being declared 'Final.'
>
>
>
>
> ------------------------------------------------------------------------------
>
>
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> Instantly run your Selenium tests across 300+ browser/OS combos.
> Get unparalleled scalability from the best Selenium testing
> platform available. Simple to use. Nothing to install. Get started
> now for free." http://p.sf.net/sfu/SauceLabs
>
>
>
> _______________________________________________ Bitcoin-development
> mailing list Bitcoin-development@lists•sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTX9bcAAoJELhWickZBkAlKqcH/RVFAr6vGgDjJvYah46StMHy
ZhKwpV1oqFCslOts6MyO+bZp9uDRlmYtnAy02CTPmlico3IyK85/+CGCGEdyiGo1
AEI2Ixr5FJs9t8uAVLyUKwOQddUFEJuZuiKXd1Wl9GqfG/z8gwdSxd08Wrq57lSH
JdwUnWOG1xBwyhgm7stqFoXgTrrnFNcE97vwsk6QMIzJG/v0suw7Lp42q7bKYaA/
J9xWSQ1cRKSPdsmu4K45oxXriqUmiqz3EouaTSQqC80OO7y8sfa96DqiHR83Vy3w
KUna5enjGqhhberWCokg3x5lCiH/IfLPrgK23iib4cg6Vm70jSQ2S2Xh/NuoDaM=
=JA5K
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-04-29 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 12:39 Gavin Andresen
2014-04-28 16:14 ` Mike Hearn
2014-04-28 20:53 ` Ryan X. Charles
2014-04-29 16:44 ` Jouke Hofman [this message]
2014-04-29 19:12 ` Gavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535FD6DC.8000002@bitonic.nl \
--to=jouke@bitonic$(echo .)nl \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox