From: Sean Gilligan <sean@msgilligan•com>
To: Pieter Wuille <pieter.wuille@gmail•com>,
Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Deprecating Bitcoin Core's regtest-specific `setgenerate` behaviour
Date: Sun, 12 Apr 2015 15:36:12 -0700 [thread overview]
Message-ID: <552AF35C.7060407@msgilligan.com> (raw)
In-Reply-To: <CAPg+sBjNkzqTUupx5QYZ_uzMwAdY4qRc+PGR5R9qCKUxxcHx7g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2127 bytes --]
I would recommend adding the new method and deprecating (as in warning
against using) the old one for one major release. Then removing it
altogether in the following major release.
I have written a Java RPC client and Groovy/Spock functional tests
<https://github.com/msgilligan/bitcoin-spock> that use the current call.
A separate `generate` or `generateblocks` call is a great idea.
However, I try to keep my tests compatible with the current stable and
unstable versions of Bitcoin Core (and the Omni Core fork) and would
have to write code that checks the RPC server version (or checks for the
presence of the new call, falling back to the old one) to support the
use cases that I need to support. Not a huge deal, but I'm probably not
the only one.
-- Sean
On 4/12/15 7:26 AM, Pieter Wuille wrote:
> Hello everyone,
>
> Bitcoin Core's `setgenerate` RPC call has had a special meaning for
> -regtest (namely instantaneously mining a number of blocks, instead of
> starting a background CPU miner).
>
> We're planning to deprecate that overloaded behaviour, and replace it
> with a separate RPC call `generate`. Is there any software or user who
> would need compatibility with the old behaviour? We're generally very
> conservative in changing RPC behaviour, but as this is not related to
> any production functionality, we may as well just switch it.
>
> Note that the bitcoin.org <http://bitcoin.org> developer documentation
> will need to be updated.
>
> --
> Pieter
>
>
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>
>
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists•sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
[-- Attachment #2: Type: text/html, Size: 3619 bytes --]
prev parent reply other threads:[~2015-04-12 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 14:26 Pieter Wuille
2015-04-12 22:36 ` Sean Gilligan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552AF35C.7060407@msgilligan.com \
--to=sean@msgilligan$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=pieter.wuille@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox