public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: 0xB10C <b10c@b10c•me>
To: bitcoin-dev@lists•linuxfoundation.org
Subject: Re: [bitcoin-dev] Proposal to Remove BIP35 P2P 'mempool' Message
Date: Mon, 1 May 2023 15:24:26 +0200	[thread overview]
Message-ID: <629aedc0-a18c-5bfc-e2b5-2f08c3fc3212@b10c.me> (raw)
In-Reply-To: <u2v2u2tpzcuyi7mkwmt3wwco6f54v5ys5nk6fdrx4d5ucy4unx@vpaz4n65lyqu>


[-- Attachment #1.1.1: Type: text/plain, Size: 1324 bytes --]

Hi Will,

I shared some numbers and feedback as comment [0] on your PR wanted to
answer question 1. for completeness here too.

> Its original intention was to be publicly callable, but it is now (in
Bitcoin Core) gated behind stricter Net Permissions which make it
accessible to trusted peers only.

Bitcoin Core does only gate processing of mempool messages on
NetPermissionFlags::Mempool when bloom filters are disabled [1]. While
these are disabled by default, more than 20% (see PR comment) of nodes
on the network have bloom filters enabled. These nodes all respond to
mempool messages with INV messages.

> 1. Are there any parties who still directly rely on the BIP35 P2P
`mempool` message?

I've been receiving on average about 20 mempool messages per hour to a
well-connected NODE_BLOOM Bitcoin Core node. I've seen multiple messages
from the user agent /BitcoinKit:0.1.0/, /bitcoinj:0.*.*/Bitcoin
Wallet:*/, /WalletKit:0.1.0/, and /bread:2.1/. Similarly, the node
responds to the clients with INVs up to the max number of 50k entries
and with smaller (bloom) filtered INVs.


0xB10C

[0]: https://github.com/bitcoin/bitcoin/pull/27426#issuecomment-1529678174
[1]:
https://github.com/bitcoin/bitcoin/blob/d89aca1bdbe52406f000e3fa8dda12c46dca9bdd/src/net_processing.cpp#LL4603C52-L4603

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 10965 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2023-05-01 13:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18  6:37 Will Clark
2023-04-18 16:57 ` David A. Harding
2023-05-01 13:24 ` 0xB10C [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=629aedc0-a18c-5bfc-e2b5-2f08c3fc3212@b10c.me \
    --to=b10c@b10c$(echo .)me \
    --cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox