From: Tamas Blummer <tamas@bitsofproof•com>
To: Mike Hearn <mike@plan99•net>
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version
Date: Thu, 20 Jun 2013 10:39:10 +0200 [thread overview]
Message-ID: <84938F7F-B75C-434B-9B7A-EC406CE42385@bitsofproof.com> (raw)
In-Reply-To: <CANEZrP1rK3z5LXd+q-SRd3pzP5QLoJSL=CMPviH4fFVGKWT69g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3370 bytes --]
Yes it is trivial. I do not think greater complexity in the system should keep us from addressing low complexity issues.
You can't blame me or others not trying to simplify scripts, if there is such a headwind simplifying a version message.
You are right there is too much fuss about this.
Tamás Blummer
Founder, CEO
http://bitsofproof.com
On 20.06.2013, at 10:31, Mike Hearn <mike@plan99•net> wrote:
> You can't eliminate the complexity (yet), otherwise you wouldn't be able to talk to old nodes. You'll have to wait until versions prior to a particular version are hard-forked off and can be safely dropped at connect time.
>
> That said the reason I'm being so grumpy about this is that compared to the complexity in the rest of the system, this is such a trivial and minor detail. It's hardly even worth thinking about. I mean, we have a scripting language full of opcodes nobody ever figured out how to use and the protocol uses a mixture of byte orders, so an optional field in the version message is really not such a big deal :)
>
>
> On Thu, Jun 20, 2013 at 10:17 AM, Tamas Blummer <tamas@bitsofproof•com> wrote:
> I agree that this can be deferred until there is an actual new field without any harm. But then remember to update the BIP37 too saying that it is optional only if flag added in BIPXX is not present.
>
> Your argument is that this complexity is already there so why not preserve it. I think eliminating complexity (that has no benefit) strengthens the system.
>
> Tamás Blummer
> http://bitsofproof.com
>
> On 20.06.2013, at 09:36, Mike Hearn <mike@plan99•net> wrote:
>
>> Sure but why not do that when there's an actual new field to add? Does anyone have a proposal for a feature that needs a new version field at the moment? There's no point changing the protocol now unless there's actually a new field to add.
>>
>> Anyway I still don't see why anyone cares about this issue. The Bitcoin protocol does not and never has required that all messages have a fixed number of fields per version. Any parser written on the assumption it did was just buggy. Look at how tx messages are relayed for the most obvious example of that pattern in action - it's actually the raw byte stream that's stored and relayed to ensure that fields added in new versions aren't dropped during round-tripping. Old versions are supposed to preserve fields from the future.
>>
>>
>>
>> On Thu, Jun 20, 2013 at 9:30 AM, Tamas Blummer <tamas@bitsofproof•com> wrote:
>> Hi Mike,
>>
>> The issue with the current parser is that those fields are conditionally optional on that there will be no subsequent fields added.
>> If there will be further fields they will become manadory.
>>
>> Why not bump the version and parse the fields as mandatory from then on? This would be backward compatible and cleaner
>> going forward.
>>
>> Tamas Blummer
>> http://bitsofproof.com
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>>
>> Build for Windows Store.
>>
>> http://p.sf.net/sfu/windows-dev2dev
>> _______________________________________________
>> Bitcoin-development mailing list
>> Bitcoin-development@lists•sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>>
>>
>
>
[-- Attachment #2: Type: text/html, Size: 14457 bytes --]
next prev parent reply other threads:[~2013-06-20 8:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 7:30 Tamas Blummer
2013-06-20 7:36 ` Mike Hearn
2013-06-20 8:17 ` Tamas Blummer
2013-06-20 8:31 ` Mike Hearn
2013-06-20 8:39 ` Tamas Blummer [this message]
2013-06-20 9:06 ` Pieter Wuille
2013-06-20 9:17 ` Mike Hearn
2013-06-20 10:37 ` Turkey Breast
2013-06-20 10:50 ` Mike Hearn
2013-06-20 10:52 ` Pieter Wuille
2013-06-20 10:58 ` Mike Hearn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84938F7F-B75C-434B-9B7A-EC406CE42385@bitsofproof.com \
--to=tamas@bitsofproof$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=mike@plan99$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox