From: Rusty Russell <rusty@rustcorp•com.au>
To: Gleb Naumenko <naumenko.gs@gmail•com>,
Bitcoin Protocol Discussion
<bitcoin-dev@lists•linuxfoundation.org>
Subject: Re: [bitcoin-dev] New BIP for p2p messages/state enabling reconciliation-based protocols (Erlay)
Date: Fri, 27 Sep 2019 11:38:27 +0930 [thread overview]
Message-ID: <87wodu7ap0.fsf@rustcorp.com.au> (raw)
In-Reply-To: <8914e269-e922-43f4-8846-9fb21a8044f3@Spark>
Hi Gleb,
Minor feedback on reading the draft:
> sendrecon:
> uint32 version Must be exactly 1 currently.
At risk of quoting myself[1]: data doesn't have requirements. Actors do.
In this case, I assume you mean "writers must set this to 1". What do
readers do if it's not?
> reqreconcil
> uint8 q Coefficient used to estimate set difference.
You describe how to calculate q (as a floating point value), but not how
to encode it?
> Every node stores sets of 128-bit truncated IDs per every peer
"*a* set..." or is it "two sets" (if you include the snapshot?).
And " *for* every peer" (maybe "which supports tx reconciliation?")
> To the best of our knowledge, PinSketch is more bandwidth efficient
> than IBLT, especially for the small differences in sets we expect to
> operate over.
Remove "To the best of our knowledge, ": that makes it sound like it's
up for debate. I've implemented and experimented with IBLT, and it's
worse.
Cheers,
Rusty.
[1] https://github.com/lightningnetwork/lightning-rfc/blob/master/CONTRIBUTING.md#writing-the-requirements
prev parent reply other threads:[~2019-09-27 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c06eeb3e-4611-4196-8d2f-f3c3470aeea3@Spark>
2019-09-25 11:28 ` Gleb Naumenko
2019-09-27 2:08 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wodu7ap0.fsf@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
--cc=naumenko.gs@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox