From: Eric Voskuil <eric@voskuil•org>
To: "David A. Harding" <dave@dtrt•org>
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists•linuxfoundation.org>
Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin Core (BIP61)
Date: Sun, 20 Oct 2019 01:13:12 -0400 [thread overview]
Message-ID: <8C87E9AF-A064-42BB-AB9D-7477C10625BF@voskuil.org> (raw)
In-Reply-To: <20191018224535.wy6f55grpfk2sncq@ganymede>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
I agree, thanks.
FWIW I’ve never been a fan of the ‘reject’ message, or its implementation.
https://github.com/bitcoin/bips/wiki/Comments:BIP-0061
e
> On Oct 18, 2019, at 18:46, David A. Harding <dave@dtrt•org> wrote:
>
> On Thu, Oct 17, 2019 at 01:16:47PM -0700, Eric Voskuil via bitcoin-dev wrote:
>> As this is a P2P protocol change it should be exposed as a version
>> increment (and a BIP) [...]
>>
>> BIP61 is explicit:
>>
>> “All implementations of the P2P protocol version 70,002 and later
>> should support the reject message.“
>
> I don't think a new BIP or a version number increment is necessary.
>
> 1. "Should support" isn't the same as "must support". See
> https://tools.ietf.org/html/rfc2119 ; by that reading,
> implementations with protocol versions above 70,002 are not required
> to support the reject message.
>
> 2. If you don't implement a BIP, as Bitcoin Core explicitly doesn't any
> more for BIP61[1], you're not bound by its conditions.
>
> -Dave
>
> [1] https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md "BIP61
> [...] Support was removed in v0.20.0"
[-- Attachment #2: Type: text/html, Size: 2217 bytes --]
next prev parent reply other threads:[~2019-10-20 5:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 0:53 Marco Falke
2019-03-06 4:00 ` Dustin Dettmer
2019-03-06 16:49 ` Andreas Schildbach
2019-03-07 13:59 ` Sjors Provoost
2019-03-07 17:58 ` Andreas Schildbach
2019-03-08 0:52 ` Gregory Maxwell
2019-03-12 17:08 ` Andreas Schildbach
2019-03-12 22:14 ` Gregory Maxwell
2019-03-13 14:29 ` Andreas Schildbach
2019-03-13 14:41 ` Oscar Guindzberg
2019-03-13 22:30 ` Dustin Dettmer
2019-03-14 9:46 ` Aymeric Vitte
2019-03-07 20:52 ` Aymeric Vitte
2019-03-08 0:09 ` Wilmer Paulino
2019-03-08 0:30 ` Eric Voskuil
2019-10-16 16:43 ` John Newbery
2019-10-17 19:38 ` Andreas Schildbach
2019-10-17 20:16 ` Eric Voskuil
2019-10-18 22:45 ` David A. Harding
2019-10-20 5:13 ` Eric Voskuil [this message]
2019-10-18 20:53 ` John Newbery
2019-10-21 8:44 ` Andreas Schildbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8C87E9AF-A064-42BB-AB9D-7477C10625BF@voskuil.org \
--to=eric@voskuil$(echo .)org \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
--cc=dave@dtrt$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox