From: Jeff Garzik <jgarzik@exmulti•com>
To: Venkatesh Srinivas <me@endeavour•zapto.org>
Cc: bitcoin-development@lists•sourceforge.net
Subject: Re: [Bitcoin-development] DragonFly BSD bitcoind patches
Date: Wed, 10 Aug 2011 22:45:36 -0400 [thread overview]
Message-ID: <CA+8xBpcwu0+KsT5sCYiOGS+_201rNTOc=Y6VToDW4wDwrVjcYA@mail.gmail.com> (raw)
In-Reply-To: <4e3f530c.6374340a.2490.7a81@mx.google.com>
On Sun, Aug 7, 2011 at 11:07 PM, Venkatesh Srinivas
<me@endeavour•zapto.org> wrote:
> Hi,
>
> Related to https://bitcointalk.org/index.php?topic=28022.0 ;
>
> Here are three patches that allow bitcoind to build and run on DragonFly
> BSD.
>
> 0001) bitcoind assumes a definition of BSD implies SO_NOSIGPIPE is
> available.
> This is not true on NetBSD, OpenBSD, and DragonFly.
applied
> 0002) main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };"
> Per discussion on the thread linked, leaving the signedness of
> pchMessageStart
> is unsafe for values > 0x80. This patch specifies 'unsigned char' in
> main.cpp
> and net.h.
>
> 0003) db.cpp has a number of uses of make_tuple and has 'using namespace
> std'
> and 'using namespace boost'. Without qualifying make_tuple, std::make_tuple
> is
> preferred, which is incorrect. This patch qualifies make_tuple.
Looks good at first glance. Creating pull requests @ github for these two.
--
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti•com
prev parent reply other threads:[~2011-08-11 2:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 3:07 Venkatesh Srinivas
2011-08-11 2:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+8xBpcwu0+KsT5sCYiOGS+_201rNTOc=Y6VToDW4wDwrVjcYA@mail.gmail.com' \
--to=jgarzik@exmulti$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=me@endeavour$(echo .)zapto.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox