public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@exmulti•com>
To: Alex Waters <ampedal@gmail•com>
Cc: bitcoin-development@lists•sourceforge.net
Subject: Re: [Bitcoin-development] Issue / Pulls timers
Date: Tue, 20 Sep 2011 14:54:46 -0400	[thread overview]
Message-ID: <CA+8xBpdF88tTHOT40=-9enrb4hsekexELSrctdHDK8QqWxGVXw@mail.gmail.com> (raw)
In-Reply-To: <CAL0fb63-zObvzirU1T6-xQnKc4=Ly2go5BBF9Q0XjqAc3o8V7A@mail.gmail.com>

On Mon, Sep 19, 2011 at 8:20 PM, Alex Waters <ampedal@gmail•com> wrote:
> I would like to propose adding timers to the pulls / issues:
>
> https://github.com/bitcoin/bitcoin/pull/523
>
> "From time to time a pull request will become outdated. If this occurs, and
> the pull is no longer automatically mergeable; it will be closed after 15
> days. This can be avoided by rebasing the commit. Pull requests closed in this
> manner will have their corresponding issue labeled stagnant.
>
> Non-bug issues with no commits will be closed after 15 days from their
> last activity.
> Issues closed in this manner will be labeled stale.
>
> Requests to reopen closed pull requests and/or issues can be submitted to
> QA@BitcoinTesting•org. "


We need to avoid a user/contributor experience of:  "my pull request
was abruptly closed with no warning"

Contributors might not track the state of the tree on a day-to-day
basis.  Thus, following the example of bugzilla.redhat.com and many
other "tracker" applications, outdated issues first initiate an
automated warning email -- usually by adding a comment to the bug
report -- that describes the policy, why the policy (closing outdated
reports) exists, and how to avoid automated report closure.

In our case, this means a "we will close pull req, unless you update
this commit in 15 days" comment should be added to the pull req.  The
comment should describe in broad terms, with links, how to rebase a
commit, what standard expectations are, etc.

Closing with no warning should be avoided.

-- 
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti•com



  reply	other threads:[~2011-09-20 18:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20  0:20 Alex Waters
2011-09-20 18:54 ` Jeff Garzik [this message]
2011-09-21  2:34   ` Alex Waters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+8xBpdF88tTHOT40=-9enrb4hsekexELSrctdHDK8QqWxGVXw@mail.gmail.com' \
    --to=jgarzik@exmulti$(echo .)com \
    --cc=ampedal@gmail$(echo .)com \
    --cc=bitcoin-development@lists$(echo .)sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox