From: Jeff Garzik <jgarzik@exmulti•com>
To: Luke-Jr <luke@dashjr•org>
Cc: bitcoin-development@lists•sourceforge.net
Subject: Re: [Bitcoin-development] [PATCH] Boost filesystem v3 support
Date: Wed, 24 Aug 2011 15:29:20 -0400 [thread overview]
Message-ID: <CA+8xBpf1Xxe4b8xQFvSKZS2Dz=3qUOuvn3X1vrSLW_Wmr_UAMw@mail.gmail.com> (raw)
In-Reply-To: <201108241521.04686.luke@dashjr.org>
On Wed, Aug 24, 2011 at 3:21 PM, Luke-Jr <luke@dashjr•org> wrote:
> On Wednesday, August 24, 2011 3:19:08 PM Jeff Garzik wrote:
>> On Fri, Aug 19, 2011 at 12:48 PM, Luke-Jr <luke@dashjr•org> wrote:
>> > This patch conditionally adapts the one line needed to support boost
>> > filesystem version 3 (default in Boost 1.46+ and required for 1.48+)
>> >
>> > I have tested it with Boost 1.41.0 to verify it still works on these
>> > older versions too.
>>
>> Your change appears to be technically correct. It is disappointing
>> for #ifdefs to crap up the code, though...
>
> It's only one line, and can be removed when the old APIs are sufficiently
> removed.
Yeah, I think it is fair to apply. Just saying... a nicer version
would be... nice. Most projects work a bit to hide this stuff in
headers, so that the actual code is a bit clean.
Now, this is a general guideline, not a hard rule. We have plenty of
#ifdef windows code already, for example.
--
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti•com
prev parent reply other threads:[~2011-08-24 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 16:48 Luke-Jr
2011-08-24 19:19 ` Jeff Garzik
2011-08-24 19:21 ` Luke-Jr
2011-08-24 19:29 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+8xBpf1Xxe4b8xQFvSKZS2Dz=3qUOuvn3X1vrSLW_Wmr_UAMw@mail.gmail.com' \
--to=jgarzik@exmulti$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=luke@dashjr$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox