From: Wladimir <laanwj@gmail•com>
To: Gavin Andresen <gavinandresen@gmail•com>
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Multisignature transaction support in the GUI
Date: Mon, 6 Feb 2012 18:27:20 +0100 [thread overview]
Message-ID: <CA+s+GJC7N3k8n335mHa7hU-Lq4uO6mu1QBLX30G+68cBtDSg3w@mail.gmail.com> (raw)
In-Reply-To: <CABsx9T09h4EQ=3BFyu-7k9D_t1ryWoC5go4yu4xwsaob9ciK6Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Mon, Feb 6, 2012 at 5:07 PM, Gavin Andresen <gavinandresen@gmail•com>wrote:
>
> Advantage of (2) is it should mean more testing of multisig, and fewer
> bug reports of "I added a multisig address via RPC but I can't send to
> it using the GUI"
>
> My opinion: I think it is worth allowing send-to-multisig-address via
> the GUI (should be a very simple change to the address validation
> logic). But creating multisig addresses via the GUI should wait until
> the next release.
>
I think we should go with (2), changing the maximum address length and
validation is very easy. We'd need to
- Change BitcoinAddressValidator::MaxAddressLength to 35
- The addresses are validated with walletmodel->validateAddress which in
turn calls CBitcoinAddress addressParsed(addr) and then isValid(). Does
this work for the new addresses?
The set of allowed characters is still the same, so BitcoinAddressValidator
doesn't have to be changed.
Advanced dialogs for constructing the addresses / adding them to the
address book could wait for 0.7.0.
Wladimir
[-- Attachment #2: Type: text/html, Size: 1593 bytes --]
next prev parent reply other threads:[~2012-02-06 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 16:07 Gavin Andresen
2012-02-06 17:27 ` Wladimir [this message]
2012-02-06 18:03 ` Wladimir
2012-02-07 11:52 ` Aidan Thornton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+s+GJC7N3k8n335mHa7hU-Lq4uO6mu1QBLX30G+68cBtDSg3w@mail.gmail.com \
--to=laanwj@gmail$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=gavinandresen@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox