From: Wladimir <laanwj@gmail•com>
To: Pieter Wuille <pieter.wuille@gmail•com>
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Reconsidering github
Date: Sat, 23 Aug 2014 17:56:26 +0200 [thread overview]
Message-ID: <CA+s+GJDraeP+n_EO2hcG7Y+4BREBUF0c8=hCwxo58gmLKm_dGQ@mail.gmail.com> (raw)
In-Reply-To: <CAPg+sBisvpQp_3f5sz3O6+4VSx5FMjDnSaBUqNVFKM+o4Qm4FA@mail.gmail.com>
>On Sat, Aug 23, 2014 at 1:38 PM, Pieter Wuille <pieter.wuille@gmail•com> >wrote:
>
> Note that we're generally aiming (though not yet enforcing) to have
> merges done through the github-merge tool, which performs the merge
> locally, shows the resulting diff, compares it with the merge done by
> github, and GnuPG signs it.
Indeed. I always use that look at and test and the merges locally
before pushing them. I never use the github merge button.
I'd recommend other people to do so as well - and as can be seen with
`git log --show-signature` it's common practice.
For browsing git history locally I find "gitk" to be a useful tool.
I'd absolutely encourage for more people to review code changes. Even
better if a few people do this through local tooling instead of the
web page. But my gut feeling is that hosting the code on github
results in many more eyes on the code overall than would be when
requiring *everyone* to use local tools. It's easy to let paranoia get
in the way of actual effectiveness.
Wladimir
next prev parent reply other threads:[~2014-08-23 15:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 12:02 Jeff Garzik
2014-08-19 12:28 ` Dāvis Mosāns
2014-08-19 14:58 ` Wladimir
2014-08-20 1:26 ` Troy Benjegerdes
2014-08-20 1:34 ` Gregory Maxwell
2014-08-20 6:24 ` Wladimir
2014-08-20 14:16 ` Mike Hearn
2014-08-23 5:59 ` Troy Benjegerdes
2014-08-23 5:53 ` Troy Benjegerdes
2014-08-30 3:33 ` Odinn Cyberguerrilla
2014-08-19 15:44 ` Bryan Bishop
2014-08-19 17:04 ` Angel Leon
2014-08-19 18:54 ` Gregory Maxwell
2014-08-22 19:20 ` xor
2014-08-22 19:31 ` Angel Leon
2014-08-23 6:17 ` Troy Benjegerdes
2014-08-23 11:38 ` Pieter Wuille
2014-08-23 12:05 ` Drak
2014-08-23 15:56 ` Wladimir [this message]
2014-08-23 11:59 ` Angel Leon
2014-08-23 14:32 ` Peter Todd
2014-08-23 17:44 ` Troy Benjegerdes
2014-08-23 20:36 ` Paul Rabahy
2014-08-23 20:54 ` Gregory Maxwell
2014-08-23 22:45 ` Peter Todd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+s+GJDraeP+n_EO2hcG7Y+4BREBUF0c8=hCwxo58gmLKm_dGQ@mail.gmail.com' \
--to=laanwj@gmail$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=pieter.wuille@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox