From: Aidan Thornton <makosoft@gmail•com>
To: Wladimir <laanwj@gmail•com>
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Multisignature transaction support in the GUI
Date: Tue, 7 Feb 2012 11:52:19 +0000 [thread overview]
Message-ID: <CAB=c7Tr6GJcyp4zGG=RJ1yEYkNYqB3J1CCYQ8mSthe=TWYNGAw@mail.gmail.com> (raw)
In-Reply-To: <CA+s+GJC7N3k8n335mHa7hU-Lq4uO6mu1QBLX30G+68cBtDSg3w@mail.gmail.com>
On Mon, Feb 6, 2012 at 5:27 PM, Wladimir <laanwj@gmail•com> wrote:
> Change BitcoinAddressValidator::MaxAddressLength to 35
> The addresses are validated with walletmodel->validateAddress which in turn
> calls CBitcoinAddress addressParsed(addr) and then isValid(). Does this work
> for the new addresses?
Should do (unless BIP 16 broke something). In fact both the GUI and
RPC commands use CBitcoinAddress and IsValid to validate addresses in
that way.
> And maybe WalletModel::sendCoins has to be changed.
> Does CScript.SetBitcoinAddress work for the new address type?
Again, should do, and it's used by the RPC commands for sending
Bitcoins as well. Really there's not a lot that needs to be changed.
I'm pretty sure even the change in MaxAddressLength is only necessary
to send coins to multisig addresses on testnet, sending them on
mainnet should just work.
prev parent reply other threads:[~2012-02-07 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 16:07 Gavin Andresen
2012-02-06 17:27 ` Wladimir
2012-02-06 18:03 ` Wladimir
2012-02-07 11:52 ` Aidan Thornton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB=c7Tr6GJcyp4zGG=RJ1yEYkNYqB3J1CCYQ8mSthe=TWYNGAw@mail.gmail.com' \
--to=makosoft@gmail$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=laanwj@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox