From: Gavin Andresen <gavinandresen@gmail•com>
To: Amir Taaki <zgenjix@yahoo•com>
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Pull 748 pay to script hash
Date: Sat, 7 Jan 2012 17:48:47 -0500 [thread overview]
Message-ID: <CABsx9T00=X+0-59+pQN6MqAox8hnqm-08gr2GA=QWfqe_qSF5g@mail.gmail.com> (raw)
In-Reply-To: <1325956875.73286.YahooMailNeo@web121006.mail.ne1.yahoo.com>
> It might be better for code review if the old pull is reverted and then this one re-requested. That will make it easier
> to see the real changes.
I count the 1 major merge then 8 commits to fix bugs or tweak
things... I just tried reverting them and stopped when I got scared
I'll accidentally revert a fix we do want to keep.
Instead, I updated my gavinandresen/master github branch to the state
of the tree just before the OP_EVAL merge, so for code review purposes
you can look at:
https://github.com/gavinandresen/bitcoin-git/compare/master...pay_to_script_hash
There are unrelated 0.6 pulls in those changes, too, but it should be
pretty obvious what is what.
--
--
Gavin Andresen
next prev parent reply other threads:[~2012-01-07 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 17:21 Amir Taaki
2012-01-07 22:48 ` Gavin Andresen [this message]
2012-01-07 23:11 ` Amir Taaki
2012-01-08 1:12 ` Gavin Andresen
2012-01-08 16:12 ` Pieter Wuille
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABsx9T00=X+0-59+pQN6MqAox8hnqm-08gr2GA=QWfqe_qSF5g@mail.gmail.com' \
--to=gavinandresen@gmail$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=zgenjix@yahoo$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox