From: Gavin Andresen <gavinandresen@gmail•com>
To: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Cc: Andreas Schildbach <andreas@schildbach•de>
Subject: [Bitcoin-development] Proposal to change payment protocol signing
Date: Mon, 28 Apr 2014 08:39:36 -0400 [thread overview]
Message-ID: <CABsx9T2v=oX5eR9yoBULPVceZFD2_d+xMF7jQJACHYP=FgWK-A@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
There is a discussion about clarifying how BIP70 signs payment requests
here:
https://github.com/bitcoin/bips/pull/41
The issue is what to do with the signature field before signing. The code
Mike and I initially wrote does this:
request.set_signature(string(""));
(sets signature to the empty string)
I think that is a mistake; it should be:
request.clear_signature();
(clears signature field, so it is not serialized at all).
So: if you are implementing, or have implemented, the payment protocol,
please chime in. I'd like to change the spec and the reference
implementation NOW, while BIP70 is still a 'Draft'.
Because this type of "hey, I'm implementing your standard and it doesn't
work the way I think it should" mistake is exactly why BIPs take a while
before being declared 'Final.'
--
--
Gavin Andresen
[-- Attachment #2: Type: text/html, Size: 1225 bytes --]
next reply other threads:[~2014-04-28 12:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 12:39 Gavin Andresen [this message]
2014-04-28 16:14 ` Mike Hearn
2014-04-28 20:53 ` Ryan X. Charles
2014-04-29 16:44 ` Jouke Hofman
2014-04-29 19:12 ` Gavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABsx9T2v=oX5eR9yoBULPVceZFD2_d+xMF7jQJACHYP=FgWK-A@mail.gmail.com' \
--to=gavinandresen@gmail$(echo .)com \
--cc=andreas@schildbach$(echo .)de \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox