From: "Jorge Timón" <jtimon@monetize•io>
To: Gavin Andresen <gavinandresen@gmail•com>,
Pieter Wuille <pieter.wuille@gmail•com>
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Timed testing
Date: Thu, 17 Apr 2014 19:43:35 +0200 [thread overview]
Message-ID: <CAC1+kJOXgMY1N+5uyyQ3Z=w=db9LPrBha=0z_2r4ND4VpsS-Vw@mail.gmail.com> (raw)
In-Reply-To: <CABsx9T23Upk+eAaHa_dPa1hQEZO1RPRMv7HfiLzbSrR14Z+NSg@mail.gmail.com>
Thank you for all the explanations on how to use regtest to reproduce
the example scenarios.
It seems like a private mode wouldn't be particularly helpful for
testing so I won't create a pull request and will just work on the
private chains separately from bitcoind.
Going back to chainparam modes in general, I've heard Sipa complain
some times about regtest being too specific, arguing that some of the
behaviors should be specified as independent parameters instead of
chainparams attributes.
One example could be bool CChainPrams::MineBlocksOnDemand() (see
https://github.com/jtimon/bitcoin/commit/5bd4bc7f3694e46568c9276f0cb26402dfb99718
).
If that was an independent parameter that people set to true when
using regtest, the blocktime param I was proposing for -timedtest
could also be implemented as an independent parameter without any need
for a new mode.
It's not clear to me if the timedtest parameter would be useful for
bitcoind testing or not, but it's just something I've noticed while
playing with this part of the code.
Sipa, is this the kind of thing you refer to when you say regtest is
too specific?
Do you have any suggestion on how to solve the issue as part of PR 3824?
Well, any suggestions from anyone on how to improve PR 3824 are
welcomed, I was just asking specifically to sipa because as said it is
my understanding that he had some complaints about regtest and I think
this is something simple enough for me to start contributing to
bitcoind. Specially given that I was going to review all that part of
the code to externally write the private mode anyway.
--
Jorge Timón
http://freico.in/
next prev parent reply other threads:[~2014-04-17 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 12:25 Jorge Timón
2014-04-17 13:00 ` Gavin Andresen
2014-04-17 15:11 ` Jorge Timón
2014-04-17 15:49 ` Mike Hearn
2014-04-17 16:09 ` Jorge Timón
2014-04-17 17:07 ` Gavin Andresen
2014-04-17 17:43 ` Jorge Timón [this message]
2014-04-17 16:35 ` Mark Friedenbach
2014-04-17 14:37 ` Brian Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC1+kJOXgMY1N+5uyyQ3Z=w=db9LPrBha=0z_2r4ND4VpsS-Vw@mail.gmail.com' \
--to=jtimon@monetize$(echo .)io \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=gavinandresen@gmail$(echo .)com \
--cc=pieter.wuille@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox