public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Srintuar <srintuar@gmail•com>
To: bitcoin-development@lists•sourceforge.net
Subject: [Bitcoin-development] Bug in key.cpp
Date: Mon, 5 May 2014 22:42:02 -0400	[thread overview]
Message-ID: <CACUQsLJwNo=GtcozCRpZU9PDDJE1fY-mnMomCUtf0WCsgGEnfA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

I think i see a bug:

line 273 of key.cpp

        if (rec<0 || rec>=3)
            return false;

Afaict, 3 is a perfectly valid value, meaning 25% of sig-> key recoveries
would fail erroneously...

[-- Attachment #2: Type: text/html, Size: 316 bytes --]

             reply	other threads:[~2014-05-06  2:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  2:42 Srintuar [this message]
2014-05-06  3:12 ` odinn.cyberguerrilla
2014-05-06  8:25   ` Pieter Wuille

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACUQsLJwNo=GtcozCRpZU9PDDJE1fY-mnMomCUtf0WCsgGEnfA@mail.gmail.com' \
    --to=srintuar@gmail$(echo .)com \
    --cc=bitcoin-development@lists$(echo .)sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox