Subject: [Bitcoin-development] Compilation warnings with -Wall

From: grarpamp <[email-masked]>
Date: Mon, 30 Jan 2012 18:27:43 -0500

This is counted from the current git master on bsd.
The first two are of note and should probably be looked at.
A little more work after those and it might be possible to
use -Wall by default as addressing even some of these
would remove tons of lines from the output :)

   1 net.cpp:141: warning: 'pszGet' may be used uninitialized in this function
   1 net.cpp:142: warning: 'pszKeyword' may be used uninitialized in
this function

   1 script.cpp:1427: warning: unused variable 'n'
   1 test/miner_tests.cpp:14: warning: unused variable 'pstate'

   1 bitcoinrpc.cpp:1533: warning: unused parameter 'parg'
   1 bitcoinrpc.cpp:2366: warning: unused parameter 'parg'
   1 db.cpp:337: warning: unused parameter 'nHeight'
   1 init.cpp:36: warning: unused parameter 'parg'
   1 init.cpp:44: warning: unused parameter 'parg'
   1 init.cpp:705: warning: unused parameter 'fAutoStart'
   1 irc.cpp:258: warning: unused parameter 'parg'
   1 json/json_spirit_reader_template.h:362: warning: unused parameter 'i'
   1 json/json_spirit_reader_template.h:381: warning: unused parameter 'end'
   1 json/json_spirit_reader_template.h:386: warning: unused parameter 'end'
   1 json/json_spirit_reader_template.h:391: warning: unused parameter 'end'
   1 json/json_spirit_reader_template.h:401: warning: unused parameter 'end'
   1 main.cpp:3130: warning: unused parameter 'pindexPrev'
   1 net.cpp:1063: warning: unused parameter 'parg'
   1 net.cpp:1209: warning: unused parameter 'parg'
   1 net.cpp:1380: warning: unused parameter 'parg'
   1 net.cpp:1480: warning: unused parameter 'parg'
   1 net.cpp:1617: warning: unused parameter 'parg'
   1 net.cpp:200: warning: unused parameter 'parg'
   1 net.cpp:619: warning: unused parameter 'parg'
  13 noui.h:40: warning: unused parameter 'parent'
  13 noui.h:40: warning: unused parameter 'style'
  13 noui.h:40: warning: unused parameter 'x'
  13 noui.h:40: warning: unused parameter 'y'
  13 noui.h:53: warning: unused parameter 'nFeeRequired'
  13 noui.h:53: warning: unused parameter 'parent'
  13 noui.h:53: warning: unused parameter 'strCaption'
  13 noui.h:58: warning: unused parameter 'nField'
  13 noui.h:58: warning: unused parameter 'strText'
  13 noui.h:62: warning: unused parameter 'fn'
  13 noui.h:70: warning: unused parameter 'message'
  23 script.h:352: warning: unused parameter 'b'
   1 serialize.h:1131: warning: unused parameter 'nType'
   1 serialize.h:1131: warning: unused parameter 'nVersion'
  31 serialize.h:176: warning: unused parameter 'a'
  53 serialize.h:460: warning: unused parameter 'nType'
  53 serialize.h:460: warning: unused parameter 'nVersion'
  66 serialize.h:482: warning: unused parameter 'nType'
  66 serialize.h:482: warning: unused parameter 'nVersion'
  66 serialize.h:505: warning: unused parameter 'nType'
  66 serialize.h:505: warning: unused parameter 'nVersion'
 611 serialize.h:747: warning: unused parameter 's'
 611 serialize.h:747: warning: unused parameter 'ser_action'
 607 serialize.h:753: warning: unused parameter 'ser_action'
 671 serialize.h:760: warning: unused parameter 'ser_action'
   1 test/test_bitcoin.cpp:25: warning: unused parameter 'parg'
  23 uint256.h:359: warning: unused parameter 'nType'
  23 uint256.h:359: warning: unused parameter 'nVersion'
  66 uint256.h:365: warning: unused parameter 'nType'
  66 uint256.h:365: warning: unused parameter 'nVersion'
  45 uint256.h:371: warning: unused parameter 'nType'
  45 uint256.h:371: warning: unused parameter 'nVersion'
   1 util.cpp:1184: warning: unused parameter 'nLine'
   1 util.cpp:1184: warning: unused parameter 'pszFile'
   1 util.cpp:1184: warning: unused parameter 'pszName'
   1 util.cpp:48: warning: unused parameter 'file'
   1 util.cpp:48: warning: unused parameter 'line'
  28 util.h:682: warning: unused parameter 'nExitCode'
  28 util.h:697: warning: unused parameter 'pfn'
   1 wallet.cpp:320: warning: unused parameter 'fFindBlock'