From: Jeremy <jlrubin@mit•edu>
To: "David A. Harding" <dave@dtrt•org>
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists•linuxfoundation.org>
Subject: Re: [bitcoin-dev] Note on Sequence Lock Upgrades Defect
Date: Sun, 5 Sep 2021 20:17:17 -0700 [thread overview]
Message-ID: <CAD5xwhh=oWtjumxn5cLJ3gs69wrhHvOTAD3gtywS8_kb7MLLqA@mail.gmail.com> (raw)
In-Reply-To: <20210906023525.nui6beegrzopwfq4@ganymede>
[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]
BIP 68 says >= 2:
*This specification defines the meaning of sequence numbers for
transactions with an nVersion greater than or equal to 2 for which the rest
of this specification relies on.*
BIP-112 says not < 2
// Fail if the transaction's version number is not set high
// enough to trigger BIP 68 rules.
if (static_cast<uint32_t>(txTo->nVersion) < 2) return false;
A further proof that this needs fix: the flawed upgradable semantic exists
in script as well as in the transaction nSeqeunce. we can't really control
the transaction version an output will be spent with in the future, so it
would be weird/bad to change the semantic in transaction version 3.
--
@JeremyRubin <https://twitter.com/JeremyRubin>
<https://twitter.com/JeremyRubin>
On Sun, Sep 5, 2021 at 7:36 PM David A. Harding <dave@dtrt•org> wrote:
> On Fri, Sep 03, 2021 at 08:32:19PM -0700, Jeremy via bitcoin-dev wrote:
> > Hi Bitcoin Devs,
> >
> > I recently noticed a flaw in the Sequence lock implementation with
> respect
> > to upgradability. It might be the case that this is protected against by
> > some transaction level policy (didn't see any in policy.cpp, but if not,
> > I've put up a blogpost explaining the defect and patching it
> > https://rubin.io/bitcoin/2021/09/03/upgradable-nops-flaw/
>
> Isn't this why BIP68 requires using tx.version=2? Wouldn't we just
> deploy any new nSequence rules with tx.version>2?
>
> -Dave
>
[-- Attachment #2: Type: text/html, Size: 3756 bytes --]
next prev parent reply other threads:[~2021-09-06 3:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 3:32 Jeremy
2021-09-05 3:19 ` Jeremy
2021-09-06 2:35 ` David A. Harding
2021-09-06 3:17 ` Jeremy [this message]
2021-09-06 6:16 ` darosior
2021-09-09 0:02 ` Antoine Riard
2021-09-09 1:04 ` Jeremy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD5xwhh=oWtjumxn5cLJ3gs69wrhHvOTAD3gtywS8_kb7MLLqA@mail.gmail.com' \
--to=jlrubin@mit$(echo .)edu \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
--cc=dave@dtrt$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox