From: Pavol Rusnak <stick@satoshilabs•com>
To: Tobin Harding <me@tobin•cc>,
Bitcoin Protocol Discussion
<bitcoin-dev@lists•linuxfoundation.org>
Subject: Re: [bitcoin-dev] segwit naming ambiguity
Date: Fri, 11 Aug 2023 12:06:22 +0200 [thread overview]
Message-ID: <CAF90AvnE+rNnbrS3Y_A7xfnAhvB+0xUnLGFv4X6pFssjocBFtw@mail.gmail.com> (raw)
In-Reply-To: <ZNW9BenWIhgX95zl@alke>
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
Here's my idea for a clean API:
1. `is_segwit()` returns true for a p2tr output
2. a function `segwit_version()` which returns an int according to segwit
version used
3. helper functions like `is_p2wpkh()`, `is_p2tr()`, `is_p2wsh()` for all
script types which all return a bool
On Fri, 11 Aug 2023 at 08:41, Tobin Harding via bitcoin-dev <
bitcoin-dev@lists•linuxfoundation.org> wrote:
> Question for OG bitcoin API designers please.
>
> If you were to see the following function
>
> `is_segwit()`
>
> would you assume it returns `true` or `false` for a p2tr transaction?
>
>
> Currently we (rust-bitcoin) are being liberal with the use of `v0` but
> its a pretty ugly. Is there an official, or widely used, name for segwit
> v0?
>
>
> Thanks,
> Tobin.
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists•linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>
--
Best Regards / S pozdravom,
Pavol "Stick" Rusnak
Co-Founder, SatoshiLabs
[-- Attachment #2: Type: text/html, Size: 1897 bytes --]
next prev parent reply other threads:[~2023-08-11 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 4:45 Tobin Harding
2023-08-11 7:38 ` symphonicbtc
2023-08-11 7:49 ` Antoine Poinsot
2023-08-11 10:06 ` Pavol Rusnak [this message]
2023-08-11 13:45 ` Andrew Poelstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF90AvnE+rNnbrS3Y_A7xfnAhvB+0xUnLGFv4X6pFssjocBFtw@mail.gmail.com \
--to=stick@satoshilabs$(echo .)com \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
--cc=me@tobin$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox