From: John Smith <witchspace81@gmail•com>
To: Mike Hearn <mike@plan99•net>
Cc: bitcoin-development@lists•sourceforge.net,
Michael Offel <Michael.Offel@web•de>
Subject: Re: [Bitcoin-development] overall bitcoin client code quality
Date: Tue, 12 Jul 2011 07:21:12 +0000 [thread overview]
Message-ID: <CAJNQ0svqH9wkbrRpJ-prXH4ue1uz0nG1jqJYkd3WtUjL7GN2EQ@mail.gmail.com> (raw)
In-Reply-To: <CANEZrP1gEx0_A+BQfJLQ1jppc=-qS1DwruR_wXsP-ctqZGGnjA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
On Mon, Jul 11, 2011 at 9:33 AM, Mike Hearn <mike@plan99•net> wrote:
> > My overall suggestion is to begin a complete rewrite, inspired by the old
> > code rather than moving a lot of "known to be somehow functional" around.
>
> This essay is old but still relevant, I think:
>
> http://www.joelonsoftware.com/articles/fog0000000069.html
>
+1
More code documentation would be helpful, and so would making the interfaces
more understandable/readable, and getting rid of the manual locking
(especially in client code!), but I don't see how that would warrant a
complete rewrite.
Some refactoring would be much safer than trying to reproduce every nook and
cranny in a rewrite.
re:4) I also don't see why boost would be a 'nonstandard dependency'. From
what I understand, a large part of the new C++0x standard is derived from
boost. Also C++ compilers are getting faster and more smart all the time, so
I absolutely don't see "build speed" as a goal.
re:6) I've already submitted a few pull requests that replace hardcoded
magic values with constants. Moving the constants to a config file is not
needed IMO because the end-user doesn't need to change them.
JS
[-- Attachment #2: Type: text/html, Size: 1654 bytes --]
next prev parent reply other threads:[~2011-07-12 7:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 22:37 Michael Offel
2011-07-10 23:07 ` Douglas Huff
2011-07-10 23:31 ` Jeff Garzik
2011-07-10 23:36 ` Matt Corallo
2011-07-11 2:01 ` Luke-Jr
2011-07-12 4:13 ` Alan Grimes
2011-07-12 5:19 ` Jeff Garzik
2011-07-11 9:33 ` Mike Hearn
2011-07-12 3:31 ` Gavin Andresen
2011-07-12 7:21 ` John Smith [this message]
2011-07-12 22:50 ` Michael Offel
2011-07-12 21:47 Michael Offel
2011-07-12 23:40 ` Gregory Maxwell
2011-07-13 0:17 ` Matt Corallo
2011-07-13 11:50 ` Mike Hearn
2011-07-13 13:04 ` Andy Parkins
2011-07-13 18:37 ` Luke-Jr
2011-07-13 21:41 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJNQ0svqH9wkbrRpJ-prXH4ue1uz0nG1jqJYkd3WtUjL7GN2EQ@mail.gmail.com \
--to=witchspace81@gmail$(echo .)com \
--cc=Michael.Offel@web$(echo .)de \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=mike@plan99$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox